OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ARM: Issue a warning when the MRRC and MRRC2 instructions are used with the same destination registers. 

* config/tc-arm.c (do_co_reg2c): Added constraint.
	* testsuite/gas/arm/dest-unpredictable.s: New.
	* testsuite/gas/arm/dest-unpredictable.l: New.
	* testsuite/gas/arm/dest-unpredictable.d: New.
This commit is contained in:
Tamar Christina 2016-08-19 12:57:20 +01:00 committed by Nick Clifton
parent 0646e07d6e
commit 873f10f02f
5 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gas/ChangeLog
View File

@ -1,3 +1,10 @@
2016-08-19 Tamar Christina <tamar.christina@arm.com>
* config/tc-arm.c (do_co_reg2c): Added constraint.
* testsuite/gas/arm/dest-unpredictable.s: New.
* testsuite/gas/arm/dest-unpredictable.l: New.
* testsuite/gas/arm/dest-unpredictable.d: New.
2016-08-19 Nick Clifton <nickc@redhat.com>
* testsuite/gas/i386/ilp32/x86-64-unwind.d: Adjust expected

8
gas/config/tc-arm.c
View File

@ -8691,6 +8691,14 @@ do_co_reg2c (void)
constraint (Rn == REG_PC, BAD_PC);
}
/* Only check the MRRC{2} variants. */
if ((inst.instruction & 0x0FF00000) == 0x0C500000)
{
/* If Rd == Rn, error that the operation is
unpredictable (example MRRC p3,#1,r1,r1,c4). */
constraint (Rd == Rn, BAD_OVERLAP);
}
inst.instruction |= inst.operands[0].reg << 8;
inst.instruction |= inst.operands[1].imm << 4;
inst.instruction |= Rd << 12;

2
gas/testsuite/gas/arm/dest-unpredictable.d Normal file
View File

@ -0,0 +1,2 @@
# name: Unpredictable MRRC and MRRC2 instructions. - ARM
# error-output: dest-unpredictable.l

5
gas/testsuite/gas/arm/dest-unpredictable.l Normal file
View File

@ -0,0 +1,5 @@
[^:]*: Assembler messages:
[^:]*:6: Error: registers may not be the same -- `mrrc p0,#1,r1,r1,c4'
[^:]*:7: Error: registers may not be the same -- `mrrc2 p0,#1,r1,r1,c4'
[^:]*:20: Error: registers may not be the same -- `mrrc p0,#1,r1,r1,c4'
[^:]*:21: Error: registers may not be the same -- `mrrc2 p0,#1,r1,r1,c4'

29
gas/testsuite/gas/arm/dest-unpredictable.s Normal file
View File

@ -0,0 +1,29 @@
.syntax unified
.arm
@ warnings
mrrc p0,#1,r1,r1,c4 @ unpredictable
mrrc2 p0,#1,r1,r1,c4 @ ditto
@ normal
mrrc p0,#1,r1,r2,c4 @ predictable
mrrc2 p0,#1,r1,r2,c4 @ ditto
mcrr p0,#1,r1,r2,c4 @ ditto
mcrr2 p0,#1,r1,r2,c4 @ ditto
mcrr p0,#1,r1,r1,c4 @ ditto
mcrr2 p0,#1,r1,r1,c4 @ ditto
.thumb
@ warnings
mrrc p0,#1,r1,r1,c4 @ unpredictable
mrrc2 p0,#1,r1,r1,c4 @ ditto
@ normal
mrrc p0,#1,r1,r2,c4 @ predictable
mrrc2 p0,#1,r1,r2,c4 @ ditto
mcrr p0,#1,r1,r2,c4 @ ditto
mcrr2 p0,#1,r1,r2,c4 @ ditto
mcrr p0,#1,r1,r1,c4 @ ditto
mcrr2 p0,#1,r1,r1,c4 @ ditto