OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Simplify tui_update_source_windows_with_addr 

After the previous changes, tui_update_source_windows_with_addr simply
updates each source-like window separately, passing the same data to
each.  So, it can be simplified by using a loop instead.

gdb/ChangeLog
2019-12-20  Tom Tromey  <tom@tromey.com>

	* tui/tui-winsource.c (tui_update_source_windows_with_addr):
	Simplify.

Change-Id: Id2ba6b3145ec005dbed1b1115118bd1ef4efb842
This commit is contained in:
Tom Tromey 2019-11-12 17:59:06 -07:00
parent 9f7540a5de
commit 88180c0824
2 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.c (tui_update_source_windows_with_addr):
Simplify.
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)

17
gdb/tui/tui-winsource.c
View File

@ -206,21 +206,12 @@ tui_source_window_base::update_source_window_as_is
void
tui_update_source_windows_with_addr (struct gdbarch *gdbarch, CORE_ADDR addr)
{
struct symtab_and_line sal {};
if (addr != 0)
{
struct symtab_and_line sal = find_pc_line (addr, 0);
if (TUI_DISASM_WIN != nullptr)
TUI_DISASM_WIN->update_source_window (gdbarch, sal);
sal = find_pc_line (addr, 0);
if (TUI_SRC_WIN != nullptr)
TUI_SRC_WIN->update_source_window (gdbarch, sal);
}
else
{
for (struct tui_source_window_base *win_info : tui_source_windows ())
win_info->erase_source_content ();
}
for (struct tui_source_window_base *win_info : tui_source_windows ())
win_info->update_source_window (gdbarch, sal);
}
/* Function to ensure that the source and/or disassemly windows