OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Abort if PT_GNU_RELRO segment doesn't fit in PT_LOAD segment 

bfd/

	PR bfd/14207
	* elf.c (assign_file_positions_for_non_load_sections): Abort if
	PT_GNU_RELRO segment doesn't fit in PT_LOAD segment.

ld/testsuite/

	PR ld/14207
	* ld-x86-64/x86-64.exp: Run pr14207.

	* ld-x86-64/pr14207.d: New file.
	* ld-x86-64/pr14207.s: Likewise.
This commit is contained in:
H.J. Lu 2012-06-12 12:55:11 +00:00
parent 3832a4d892
commit 8981c88a1e
6 changed files with 53 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2012-06-12 H.J. Lu <hongjiu.lu@intel.com>
PR bfd/14207
* elf.c (assign_file_positions_for_non_load_sections): Abort if
PT_GNU_RELRO segment doesn't fit in PT_LOAD segment.
2012-06-12 Alan Modra <amodra@gmail.com>
PR ld/14207

5
bfd/elf.c
View File

@ -4931,6 +4931,11 @@ assign_file_positions_for_non_load_sections (bfd *abfd,
&& lp->p_vaddr + lp->p_filesz >= link_info->relro_end)
break;
}
/* PR ld/14207. If the RELRO segment doesn't fit in the
LOAD segment, it should be removed. */
if (lp == (phdrs + count))
abort ();
}
else
{

8
ld/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2012-06-12 H.J. Lu <hongjiu.lu@intel.com>
PR ld/14207
* ld-x86-64/x86-64.exp: Run pr14207.
* ld-x86-64/pr14207.d: New file.
* ld-x86-64/pr14207.s: Likewise.
2012-06-11 H.J. Lu <hongjiu.lu@intel.com>
PR ld/14215

9
ld/testsuite/ld-x86-64/pr14207.d Normal file
View File

@ -0,0 +1,9 @@
#name: PR ld/14207
#as: --64
#ld: -melf_x86_64 -shared -z relro -z now
#readelf: -l --wide
#failif
#...
NULL +.*
#...

24
ld/testsuite/ld-x86-64/pr14207.s Normal file
View File

@ -0,0 +1,24 @@
.section .ctors, "aw"
.space 0x10, 1
.section .dtors, "aw"
.space 0x10, 2
.section .jcr, "aw"
.space 0x8, 3
.section .data.rel.ro
.p2align 4
.space 0x20, 3
.section .dynamic
.space 0xb0, 2
.section .got
.space 0x2a8, 4
.bss
.zero 0x840

1
ld/testsuite/ld-x86-64/x86-64.exp
View File

@ -209,6 +209,7 @@ run_dump_test "pr13947"
run_dump_test "pr12570a"
run_dump_test "pr12570b"
run_dump_test "pr14215"
run_dump_test "pr14207"
if { ![istarget "x86_64-*-linux*"] && ![istarget "x86_64-*-nacl*"]} {
return