OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use regcache->tdesc instead of arm_hwcap 

arm_hwcap is a global variable, and we should avoid using it as much
as we can.  Instead of checking arm_hwcap, we can check whether
regcache->tdesc is a certain kind of target description.  This is
what this patch does.

gdb/gdbserver:

2015-07-30  Yao Qi  <yao.qi@linaro.org>

	* linux-arm-low.c (arm_fill_wmmxregset): Don't use arm_hwcap.
	Use regcache->tdesc instead.
	(arm_store_wmmxregset): Likewise.
	(arm_fill_vfpregset): Likewise.
	(arm_store_vfpregset): Likewise.
This commit is contained in:
Yao Qi 2015-07-30 15:07:39 +01:00
parent deca266c89
commit 89abb03951
2 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,11 @@
2015-07-30 Yao Qi <yao.qi@linaro.org>
* linux-arm-low.c (arm_fill_wmmxregset): Don't use arm_hwcap.
Use regcache->tdesc instead.
(arm_store_wmmxregset): Likewise.
(arm_fill_vfpregset): Likewise.
(arm_store_vfpregset): Likewise.
2015-07-30 Yao Qi <yao.qi@linaro.org>
* linux-arm-low.c: Include arch/arm.h.

24
gdb/gdbserver/linux-arm-low.c
View File

@ -185,7 +185,7 @@ arm_fill_wmmxregset (struct regcache *regcache, void *buf)
{
int i;
if (!(arm_hwcap & HWCAP_IWMMXT))
if (regcache->tdesc != tdesc_arm_with_iwmmxt)
return;
for (i = 0; i < 16; i++)
@ -202,7 +202,7 @@ arm_store_wmmxregset (struct regcache *regcache, const void *buf)
{
int i;
if (!(arm_hwcap & HWCAP_IWMMXT))
if (regcache->tdesc != tdesc_arm_with_iwmmxt)
return;
for (i = 0; i < 16; i++)
@ -219,13 +219,13 @@ arm_fill_vfpregset (struct regcache *regcache, void *buf)
{
int i, num, base;
if (!(arm_hwcap & HWCAP_VFP))
return;
if ((arm_hwcap & (HWCAP_VFPv3 | HWCAP_VFPv3D16)) == HWCAP_VFPv3)
if (regcache->tdesc == tdesc_arm_with_neon
|| regcache->tdesc == tdesc_arm_with_vfpv3)
num = 32;
else
else if (regcache->tdesc == tdesc_arm_with_vfpv2)
num = 16;
else
return;
base = find_regno (regcache->tdesc, "d0");
for (i = 0; i < num; i++)
@ -239,13 +239,13 @@ arm_store_vfpregset (struct regcache *regcache, const void *buf)
{
int i, num, base;
if (!(arm_hwcap & HWCAP_VFP))
return;
if ((arm_hwcap & (HWCAP_VFPv3 | HWCAP_VFPv3D16)) == HWCAP_VFPv3)
if (regcache->tdesc == tdesc_arm_with_neon
|| regcache->tdesc == tdesc_arm_with_vfpv3)
num = 32;
else
else if (regcache->tdesc == tdesc_arm_with_vfpv2)
num = 16;
else
return;
base = find_regno (regcache->tdesc, "d0");
for (i = 0; i < num; i++)