OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

constify ui_out_impl 

This patch constifies ui_out_impl in struct ui_out, and various
instances of ui_out_impl.

This removes a couple of FIXME comments (near cli_ui_out_impl and
mi_ui_out_impl) that did not make sense to me.

Tested by rebuilding.

2014-02-28  Tom Tromey  <tromey@redhat.com>

	* cli-out.c (cli_ui_out_impl): Now const.  Remove comment.
	* cli-out.h (cli_ui_out_impl): Now const.
	* mi/mi-out.c (mi_ui_out_impl): Now const.  Remove comment.
	* ui-out.c (struct ui_out) <impl>: Now const.
	(default_ui_out_impl): Now const.
	(ui_out_new): Make 'impl' parameter const.
	* ui-out.h (ui_out_new): Update.
This commit is contained in:
Tom Tromey 2013-12-23 20:53:23 -07:00
parent 02fe846e43
commit 89de4da46b
6 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/ChangeLog
View File

@ -1,3 +1,13 @@
2014-02-28 Tom Tromey <tromey@redhat.com>
* cli-out.c (cli_ui_out_impl): Now const. Remove comment.
* cli-out.h (cli_ui_out_impl): Now const.
* mi/mi-out.c (mi_ui_out_impl): Now const. Remove comment.
* ui-out.c (struct ui_out) <impl>: Now const.
(default_ui_out_impl): Now const.
(ui_out_new): Make 'impl' parameter const.
* ui-out.h (ui_out_new): Update.
2014-02-27 Mark Kettenis <kettenis@gnu.org>
* solib-svr4.c (svr4_read_so_list): Initialize first_l_name to 0.

5
gdb/cli-out.c
View File

@ -349,10 +349,7 @@ field_separator (void)
/* This is the CLI ui-out implementation functions vector */
/* FIXME: This can be initialized dynamically after default is set to
handle initial output in main.c */
struct ui_out_impl cli_ui_out_impl =
const struct ui_out_impl cli_ui_out_impl =
{
cli_table_begin,
cli_table_body,

2
gdb/cli-out.h
View File

@ -37,7 +37,7 @@ struct cli_ui_out_data
int suppress_output;
};
extern struct ui_out_impl cli_ui_out_impl;
extern const struct ui_out_impl cli_ui_out_impl;
extern struct ui_out *cli_out_new (struct ui_file *stream);

5
gdb/mi/mi-out.c
View File

@ -67,10 +67,7 @@ static int mi_redirect (struct ui_out *uiout, struct ui_file *outstream);
/* This is the MI ui-out implementation functions vector */
/* FIXME: This can be initialized dynamically after default is set to
handle initial output in main.c */
struct ui_out_impl mi_ui_out_impl =
static const struct ui_out_impl mi_ui_out_impl =
{
mi_table_begin,
mi_table_body,

6
gdb/ui-out.c
View File

@ -102,7 +102,7 @@ struct ui_out
{
int flags;
/* Specific implementation of ui-out. */
struct ui_out_impl *impl;
const struct ui_out_impl *impl;
void *data;
/* Current level. */
@ -198,7 +198,7 @@ static void default_data_destroy (struct ui_out *uiout);
/* This is the default ui-out implementation functions vector. */
struct ui_out_impl default_ui_out_impl =
const struct ui_out_impl default_ui_out_impl =
{
default_table_begin,
default_table_body,
@ -1095,7 +1095,7 @@ ui_out_query_field (struct ui_out *uiout, int colno,
/* Initalize private members at startup. */
struct ui_out *
ui_out_new (struct ui_out_impl *impl, void *data,
ui_out_new (const struct ui_out_impl *impl, void *data,
int flags)
{
struct ui_out *uiout = XNEW (struct ui_out);

2
gdb/ui-out.h
View File

@ -234,7 +234,7 @@ extern void uo_field_string (struct ui_out *uiout, int fldno, int width,
/* Create a ui_out object */
extern struct ui_out *ui_out_new (struct ui_out_impl *impl,
extern struct ui_out *ui_out_new (const struct ui_out_impl *impl,
void *data,
int flags);