OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

linux-record.c:record_linux_system_call: fix -Wpointer-sign 

$ make WERROR_CFLAGS="-Wpointer-sign -Werror" linux-record.o 2>&1 1>/dev/null
...
../../src/gdb/linux-record.c: In function ‘record_linux_system_call’:
../../src/gdb/linux-record.c:1152:9: error: pointer targets in passing argument 3 of ‘regcache_raw_read_signed’ differ in signedness [-Werror=pointer-sign]
In file included from ../../src/gdb/linux-record.c:23:0:
../../src/gdb/regcache.h:76:3: note: expected ‘long int *’ but argument is of type ‘long unsigned int *’
../../src/gdb/linux-record.c:1186:13: error: pointer targets in passing argument 3 of ‘regcache_raw_read_signed’ differ in signedness [-Werror=pointer-sign]
In file included from ../../src/gdb/linux-record.c:23:0:
../../src/gdb/regcache.h:76:3: note: expected ‘long int *’ but argument is of type ‘long unsigned int *’

I believe the read_signed calls are correct, and the variables are in
the wrong.

Tested on x86_64 Fedora 17.

gdb/
2013-03-07  Pedro Alves  <palves@redhat.com>

	* linux-record.c (record_linux_system_call) <gdb_sys_msgrcv,
	RECORD_MSGRCV>: Pass a signed variable to
	regcache_raw_read_signed, instead of an unsigned one.
This commit is contained in:
Pedro Alves 2013-03-07 18:29:05 +00:00
parent 99f0a309a9
commit 8ac2c12b84
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2013-03-07 Pedro Alves <palves@redhat.com>
* linux-record.c (record_linux_system_call) <gdb_sys_msgrcv,
RECORD_MSGRCV>: Pass a signed variable to
regcache_raw_read_signed, instead of an unsigned one.
2013-03-07 Pedro Alves <palves@redhat.com>
* remote-notif.c (notif_debug): Change type to int.

7
gdb/linux-record.c
View File

@ -1148,10 +1148,11 @@ Do you want to stop the program?"),
case gdb_sys_msgrcv:
{
ULONGEST msgp;
LONGEST l;
regcache_raw_read_signed (regcache, tdep->arg3, &tmpulongest);
regcache_raw_read_signed (regcache, tdep->arg3, &l);
regcache_raw_read_unsigned (regcache, tdep->arg2, &msgp);
tmpint = (int) tmpulongest + tdep->size_long;
tmpint = l + tdep->size_long;
if (record_arch_list_add_mem ((CORE_ADDR) msgp, tmpint))
return -1;
}
@ -1180,7 +1181,7 @@ Do you want to stop the program?"),
break;
case RECORD_MSGRCV:
{
ULONGEST second;
LONGEST second;
ULONGEST ptr;
regcache_raw_read_signed (regcache, tdep->arg3, &second);