OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix warn-unused-return message.

Browse Source 
gold/
	* plugin.cc (link_or_copy_file): Remove newlines from warning messages.
	Add pedantic check for return value from ::write.
This commit is contained in:
Cary Coutant 2018-03-23 23:33:47 -07:00
parent 3215deaaa6
commit 8da9a904f4
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gold/ChangeLog
View File

@ -1,3 +1,8 @@
2018-03-23 Cary Coutant <ccoutant@gmail.com>
* plugin.cc (link_or_copy_file): Remove newlines from warning messages.
Add pedantic check for return value from ::write.
2018-03-23 Cary Coutant <ccoutant@gmail.com>
* debug.h (DEBUG_PLUGIN): New constant.

13
gold/plugin.cc
View File

@ -568,19 +568,26 @@ link_or_copy_file(const char* inname, const char* outname)
int in = ::open(inname, O_RDONLY);
if (in < 0)
{
gold_warning(_("%s: can't open (%s)\n"), inname, strerror(errno));
gold_warning(_("%s: can't open (%s)"), inname, strerror(errno));
return false;
}
int out = ::open(outname, O_CREAT | O_TRUNC | O_WRONLY, 0600);
if (out < 0)
{
gold_warning(_("%s: can't create (%s)\n"), outname, strerror(errno));
gold_warning(_("%s: can't create (%s)"), outname, strerror(errno));
::close(in);
return false;
}
ssize_t len;
while ((len = ::read(in, buf, sizeof(buf))) > 0)
static_cast<void>(::write(out, buf, len));
{
if (::write(out, buf, len) != len)
{
gold_warning(_("%s: write error while making copy of file (%s)"),
inname, strerror(errno));
break;
}
}
::close(in);
::close(out);
return true;