Fix warn-unused-return message.
gold/ * plugin.cc (link_or_copy_file): Remove newlines from warning messages. Add pedantic check for return value from ::write.
This commit is contained in:
parent
3215deaaa6
commit
8da9a904f4
|
@ -1,3 +1,8 @@
|
||||||
|
2018-03-23 Cary Coutant <ccoutant@gmail.com>
|
||||||
|
|
||||||
|
* plugin.cc (link_or_copy_file): Remove newlines from warning messages.
|
||||||
|
Add pedantic check for return value from ::write.
|
||||||
|
|
||||||
2018-03-23 Cary Coutant <ccoutant@gmail.com>
|
2018-03-23 Cary Coutant <ccoutant@gmail.com>
|
||||||
|
|
||||||
* debug.h (DEBUG_PLUGIN): New constant.
|
* debug.h (DEBUG_PLUGIN): New constant.
|
||||||
|
|
|
@ -568,19 +568,26 @@ link_or_copy_file(const char* inname, const char* outname)
|
||||||
int in = ::open(inname, O_RDONLY);
|
int in = ::open(inname, O_RDONLY);
|
||||||
if (in < 0)
|
if (in < 0)
|
||||||
{
|
{
|
||||||
gold_warning(_("%s: can't open (%s)\n"), inname, strerror(errno));
|
gold_warning(_("%s: can't open (%s)"), inname, strerror(errno));
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
int out = ::open(outname, O_CREAT | O_TRUNC | O_WRONLY, 0600);
|
int out = ::open(outname, O_CREAT | O_TRUNC | O_WRONLY, 0600);
|
||||||
if (out < 0)
|
if (out < 0)
|
||||||
{
|
{
|
||||||
gold_warning(_("%s: can't create (%s)\n"), outname, strerror(errno));
|
gold_warning(_("%s: can't create (%s)"), outname, strerror(errno));
|
||||||
::close(in);
|
::close(in);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
ssize_t len;
|
ssize_t len;
|
||||||
while ((len = ::read(in, buf, sizeof(buf))) > 0)
|
while ((len = ::read(in, buf, sizeof(buf))) > 0)
|
||||||
static_cast<void>(::write(out, buf, len));
|
{
|
||||||
|
if (::write(out, buf, len) != len)
|
||||||
|
{
|
||||||
|
gold_warning(_("%s: write error while making copy of file (%s)"),
|
||||||
|
inname, strerror(errno));
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
::close(in);
|
::close(in);
|
||||||
::close(out);
|
::close(out);
|
||||||
return true;
|
return true;
|
||||||
|
|
Loading…
Reference in New Issue