Re: PowerPC PIC vs. DLL TLS issues

A bug crept into commit f749f26eea, which could cause linker
segfaults when creating PIEs.  This patch fixes it.

	* elf64-ppc.c (ppc64_elf_size_dynamic_sections): Do allocate
	space for local got non-tls relocs when PIE.
This commit is contained in:
Alan Modra 2019-10-07 23:14:31 +10:30
parent 60ff3cd784
commit 93370e8e7b
2 changed files with 8 additions and 1 deletions

View File

@ -1,3 +1,8 @@
2019-10-07 Alan Modra <amodra@gmail.com>
* elf64-ppc.c (ppc64_elf_size_dynamic_sections): Do allocate
space for local got non-tls relocs when PIE.
2019-10-07 Alan Modra <amodra@gmail.com>
* elflink.c (elf_fixup_link_order): Don't attempt to find

View File

@ -9814,7 +9814,9 @@ ppc64_elf_size_dynamic_sections (bfd *output_bfd,
htab->elf.irelplt->size += rel_size;
htab->got_reli_size += rel_size;
}
else if (bfd_link_dll (info))
else if (bfd_link_pic (info)
&& !(ent->tls_type != 0
&& bfd_link_executable (info)))
{
asection *srel = ppc64_elf_tdata (ibfd)->relgot;
srel->size += rel_size;