From 95d0f04a0b7b84ec4deb74cbe28917b0477da4d0 Mon Sep 17 00:00:00 2001 From: Dave Anglin Date: Wed, 8 Jan 2003 02:19:23 +0000 Subject: [PATCH] * elf32-hppa.c (final_link_relocate): For all DP relative relocations, adjust addil instructions if the symbol has no section. --- bfd/ChangeLog | 5 +++++ bfd/elf32-hppa.c | 13 ++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index fde02c8656..81f78a0010 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2003-01-07 John David Anglin + + * elf32-hppa.c (final_link_relocate): For all DP relative relocations, + adjust addil instructions if the symbol has no section. + 2003-01-07 DJ Delorie * elf32-xstormy16.c (xstormy16_elf_howto_table): Make REL_12 not diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c index f8c88b1558..2646f3dc4e 100644 --- a/bfd/elf32-hppa.c +++ b/bfd/elf32-hppa.c @@ -3416,15 +3416,14 @@ final_link_relocate (input_section, contents, rel, value, htab, sym_sec, h) case R_PARISC_DPREL14R: case R_PARISC_DPREL14F: /* For all the DP relative relocations, we need to examine the symbol's - section. If it's a code section, then "data pointer relative" makes - no sense. In that case we don't adjust the "value", and for 21 bit - addil instructions, we change the source addend register from %dp to - %r0. This situation commonly arises when a variable's "constness" + section. If it has no section or if it's a code section, then + "data pointer relative" makes no sense. In that case we don't + adjust the "value", and for 21 bit addil instructions, we change the + source addend register from %dp to %r0. This situation commonly + arises for undefined weak symbols and when a variable's "constness" is declared differently from the way the variable is defined. For instance: "extern int foo" with foo defined as "const int foo". */ - if (sym_sec == NULL) - break; - if ((sym_sec->flags & SEC_CODE) != 0) + if (sym_sec == NULL || (sym_sec->flags & SEC_CODE) != 0) { if ((insn & ((0x3f << 26) | (0x1f << 21))) == (((int) OP_ADDIL << 26) | (27 << 21)))