OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a potential illegal array access in the D30V disassembler. 

* d30v-dis.c (print_insn): Check that operand index is valid
	before attempting to access the operands array.
This commit is contained in:
Nick Clifton 2019-10-29 10:25:09 +00:00
parent 993a00a986
commit 9adb259150
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2019-10-29 Nick Clifton <nickc@redhat.com>
* d30v-dis.c (print_insn): Check that operand index is valid
before attempting to access the operands array.
2019-10-29 Nick Clifton <nickc@redhat.com>
* ia64-opc.c (locate_opcode_ent): Prevent a negative shift when

5
opcodes/d30v-dis.c
View File

@ -23,6 +23,7 @@
#include "opcode/d30v.h"
#include "disassemble.h"
#include "opintl.h"
#include "libiberty.h"
#define PC_MASK 0xFFFFFFFF
@ -313,7 +314,9 @@ print_insn (struct disassemble_info *info,
(*info->fprintf_func) (info->stream, "0x%x", val);
}
/* If there is another operand, then write a comma and space. */
if (insn->form->operands[opind] && !(found_control && opind == 2))
if (opind < (int) ARRAY_SIZE (insn->form->operands)
&& insn->form->operands[opind]
&& !(found_control && opind == 2))
need_comma = 1;
}
if (need_paren)