OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

-Wwrite-strings: execute_command calls with string literals

Browse Source 
This is ugly, but it's just making the uglyness explicit.

All these places would better be calling some API function directly
instead of going through execute_command & friends...

gdb/ChangeLog:
2017-04-05  Pedro Alves  <palves@redhat.com>

	* event-top.c (command_line_handler): Add cast to execute_command
	call.
	* record-btrace.c (cmd_record_btrace_bts_start)
	(cmd_record_btrace_pt_start, cmd_record_btrace_start)
	(cmd_record_btrace_start): Add cast to execute_command call.
	* record-full.c (record_full_goto_insn):
	* record.c (record_start, record_stop): Add cast to
	execute_command_to_string calls.
	(cmd_record_start): Add cast to execute_command calls.
This commit is contained in:
Pedro Alves 2017-04-05 19:21:36 +01:00
parent 2adadf5170
commit 9b2eba3dcc
5 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/ChangeLog
View File

@ -1,3 +1,15 @@
2017-04-05 Pedro Alves <palves@redhat.com>
* event-top.c (command_line_handler): Add cast to execute_command
call.
* record-btrace.c (cmd_record_btrace_bts_start)
(cmd_record_btrace_pt_start, cmd_record_btrace_start)
(cmd_record_btrace_start): Add cast to execute_command call.
* record-full.c (record_full_goto_insn):
* record.c (record_start, record_stop): Add cast to
execute_command_to_string calls.
(cmd_record_start): Add cast to execute_command calls.
2017-04-05 Pedro Alves <palves@redhat.com>
* python/python-internal.h (gdb_PyArg_ParseTupleAndKeywords): New

2
gdb/event-top.c
View File

@ -766,7 +766,7 @@ command_line_handler (char *rl)
hung up but GDB is still alive. In such a case, we just quit
gdb killing the inferior program too. */
printf_unfiltered ("quit\n");
execute_command ("quit", 1);
execute_command ((char *) "quit", 1);
}
else if (cmd == NULL)
{

8
gdb/record-btrace.c
View File

@ -2897,7 +2897,7 @@ cmd_record_btrace_bts_start (char *args, int from_tty)
TRY
{
execute_command ("target record-btrace", from_tty);
execute_command ((char *) "target record-btrace", from_tty);
}
CATCH (exception, RETURN_MASK_ALL)
{
@ -2919,7 +2919,7 @@ cmd_record_btrace_pt_start (char *args, int from_tty)
TRY
{
execute_command ("target record-btrace", from_tty);
execute_command ((char *) "target record-btrace", from_tty);
}
CATCH (exception, RETURN_MASK_ALL)
{
@ -2941,7 +2941,7 @@ cmd_record_btrace_start (char *args, int from_tty)
TRY
{
execute_command ("target record-btrace", from_tty);
execute_command ((char *) "target record-btrace", from_tty);
}
CATCH (exception, RETURN_MASK_ALL)
{
@ -2949,7 +2949,7 @@ cmd_record_btrace_start (char *args, int from_tty)
TRY
{
execute_command ("target record-btrace", from_tty);
execute_command ((char *) "target record-btrace", from_tty);
}
CATCH (exception, RETURN_MASK_ALL)
{

2
gdb/record-full.c
View File

@ -2788,7 +2788,7 @@ record_full_goto_insn (struct record_full_entry *entry,
static void
cmd_record_full_start (char *args, int from_tty)
{
execute_command ("target record-full", from_tty);
execute_command ((char *) "target record-full", from_tty);
}
static void

14
gdb/record.c
View File

@ -99,25 +99,25 @@ record_start (const char *method, const char *format, int from_tty)
if (method == NULL)
{
if (format == NULL)
execute_command_to_string ("record", from_tty);
execute_command_to_string ((char *) "record", from_tty);
else
error (_("Invalid format."));
}
else if (strcmp (method, "full") == 0)
{
if (format == NULL)
execute_command_to_string ("record full", from_tty);
execute_command_to_string ((char *) "record full", from_tty);
else
error (_("Invalid format."));
}
else if (strcmp (method, "btrace") == 0)
{
if (format == NULL)
execute_command_to_string ("record btrace", from_tty);
execute_command_to_string ((char *) "record btrace", from_tty);
else if (strcmp (format, "bts") == 0)
execute_command_to_string ("record btrace bts", from_tty);
execute_command_to_string ((char *) "record btrace bts", from_tty);
else if (strcmp (format, "pt") == 0)
execute_command_to_string ("record btrace pt", from_tty);
execute_command_to_string ((char *) "record btrace pt", from_tty);
else
error (_("Invalid format."));
}
@ -130,7 +130,7 @@ record_start (const char *method, const char *format, int from_tty)
void
record_stop (int from_tty)
{
execute_command_to_string ("record stop", from_tty);
execute_command_to_string ((char *) "record stop", from_tty);
}
/* See record.h. */
@ -265,7 +265,7 @@ show_record_debug (struct ui_file *file, int from_tty,
static void
cmd_record_start (char *args, int from_tty)
{
execute_command ("target record-full", from_tty);
execute_command ((char *) "target record-full", from_tty);
}
/* Truncate the record log from the present point