OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove dead code and "current" field from MI thread output doc 

The MI documentation says that -thread-info output contains a "current"
field in the current thread tuple, with the value "*".  Current GDB
master does not do this, and I couldn't find any GDB version that did.
I suspect that it was never the case.

The code that would correspond to this in print_thread_info_1 is
essentially dead code.  The calls to uiout->text end up in
mi_out::do_text, which is empty.

This patch removes the documentation bit and the dead code.  This
"current" field is not necessary, since -thread-info outputs a
"current-thread-id" field.

gdb/ChangeLog:

	* thread.c (print_thread_info_1): Remove dead code.

gdb/doc/ChangeLog:

	* gdb.texinfo (GDB/MI Thread Commands): Remove "current" field
	from -thread-info output.
This commit is contained in:
Simon Marchi 2017-04-21 21:45:15 -04:00 committed by Simon Marchi
parent b8ac4fa43d
commit 9be21bb4d4
4 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2017-04-21 Simon Marchi <simon.marchi@ericsson.com>
* thread.c (print_thread_info_1): Remove dead code.
2017-04-21 Jan Kratochvil <jan.kratochvil@redhat.com>
* aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if

5
gdb/doc/ChangeLog
View File

@ -1,3 +1,8 @@
2017-04-21 Simon Marchi <simon.marchi@ericsson.com>
* gdb.texinfo (GDB/MI Thread Commands): Remove "current" field
from -thread-info output.
2017-03-28 Anton Kolesov <anton.kolesov@synopsys.com>
* gdb.texinfo (Synopsys ARC): Document "set debug arc 2".

3
gdb/doc/gdb.texinfo
View File

@ -28088,9 +28088,6 @@ The result is a list of threads. The following attributes are
defined for a given thread:
@table @samp
@item current
This field exists only for the current thread. It has the value @samp{*}.
@item id
The global identifier that @value{GDBN} uses to refer to the thread.

10
gdb/thread.c
View File

@ -1308,15 +1308,7 @@ print_thread_info_1 (struct ui_out *uiout, char *requested_threads,
chain2 = make_cleanup_ui_out_tuple_begin_end (uiout, NULL);
if (uiout->is_mi_like_p ())
{
/* Compatibility. */
if (tp->ptid == current_ptid)
uiout->text ("* ");
else
uiout->text (" ");
}
else
if (!uiout->is_mi_like_p ())
{
if (tp->ptid == current_ptid)
uiout->field_string ("current", "*");