OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix invalid strcpy on unterminated buffer

Browse Source 
* read.c (do_repeat_with_expander): Use memmove instead of strcpy
on unterminated string buffer.
This commit is contained in:
Andreas Schwab 2018-08-20 16:55:05 +02:00
parent 9cf7e5687f
commit 9dcbfff1e0
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2018-08-21 Andreas Schwab <schwab@suse.de>
* read.c (do_repeat_with_expander): Use memmove instead of strcpy
on unterminated string buffer.
2018-08-21 Alan Modra <amodra@gmail.com>
* config/tc-ppc.c (md_assemble): Delay counting of optional

3
gas/read.c
View File

@ -3117,7 +3117,8 @@ do_repeat_with_expander (size_t count,
sub = strstr (processed.ptr, expander);
len = sprintf (sub, "%lu", (unsigned long) count);
gas_assert (len < 8);
strcpy (sub + len, sub + 8);
memmove (sub + len, sub + 8,
processed.ptr + processed.len - (sub + 8));
processed.len -= (8 - len);
sb_add_sb (& many, & processed);
sb_kill (& processed);