From a1d1fa3e417b4bd8e79e2a731f9c6089e2d5f747 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Mon, 1 Jun 2020 15:21:33 +0100 Subject: [PATCH] gdb: Convert language la_value_print field to a method This commit changes the language_data::la_value_print function pointer member variable into a member function of language_defn. There should be no user visible changes after this commit. gdb/ChangeLog: * ada-lang.c (ada_language_data): Delete la_value_print initializer. (ada_language::value_print): New member function. * c-lang.c (c_language_data): Delete la_value_print initializer. (cplus_language_data): Likewise. (asm_language_data): Likewise. (minimal_language_data): Likewise. * d-lang.c (d_language_data): Likewise. * f-lang.c (f_language_data): Likewise. * go-lang.c (go_language_data): Likewise. * language.c (unk_lang_value_print): Delete. (language_defn::value_print): Define new member function. (unknown_language_data): Delete la_value_print initializer. (unknown_language::value_print): New member function. (auto_language_data): Delete la_value_print initializer. (auto_language::value_print): New member function. * language.h (language_data): Delete la_value_print field. (language_defn::value_print): Declare new member function. (LA_VALUE_PRINT): Update call to value_print. * m2-lang.c (m2_language_data): Delete la_value_print initializer. * objc-lang.c (objc_language_data): Likewise. * opencl-lang.c (opencl_language_data): Likewise. * p-lang.c (pascal_language_data): Likewise. (pascal_language::value_print): New member function. * rust-lang.c (rust_language_data): Delete la_value_print initializer. --- gdb/ChangeLog | 29 +++++++++++++++++++++++++++++ gdb/ada-lang.c | 9 ++++++++- gdb/c-lang.c | 4 ---- gdb/d-lang.c | 1 - gdb/f-lang.c | 1 - gdb/go-lang.c | 1 - gdb/language.c | 38 +++++++++++++++++++++++++------------- gdb/language.h | 11 +++++------ gdb/m2-lang.c | 1 - gdb/objc-lang.c | 1 - gdb/opencl-lang.c | 1 - gdb/p-lang.c | 9 ++++++++- gdb/rust-lang.c | 1 - 13 files changed, 75 insertions(+), 32 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2b8ea9617f..d1acf26d8e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,32 @@ +2020-06-17 Andrew Burgess + + * ada-lang.c (ada_language_data): Delete la_value_print + initializer. + (ada_language::value_print): New member function. + * c-lang.c (c_language_data): Delete la_value_print initializer. + (cplus_language_data): Likewise. + (asm_language_data): Likewise. + (minimal_language_data): Likewise. + * d-lang.c (d_language_data): Likewise. + * f-lang.c (f_language_data): Likewise. + * go-lang.c (go_language_data): Likewise. + * language.c (unk_lang_value_print): Delete. + (language_defn::value_print): Define new member function. + (unknown_language_data): Delete la_value_print initializer. + (unknown_language::value_print): New member function. + (auto_language_data): Delete la_value_print initializer. + (auto_language::value_print): New member function. + * language.h (language_data): Delete la_value_print field. + (language_defn::value_print): Declare new member function. + (LA_VALUE_PRINT): Update call to value_print. + * m2-lang.c (m2_language_data): Delete la_value_print initializer. + * objc-lang.c (objc_language_data): Likewise. + * opencl-lang.c (opencl_language_data): Likewise. + * p-lang.c (pascal_language_data): Likewise. + (pascal_language::value_print): New member function. + * rust-lang.c (rust_language_data): Delete la_value_print + initializer. + 2020-06-17 Andrew Burgess * ada-lang.c (ada_watch_location_expression): Rename to diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 392b1a679c..85483d4e4b 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -13765,7 +13765,6 @@ extern const struct language_data ada_language_data = emit_char, /* Function to print single char (not used) */ ada_print_typedef, /* Print a typedef using appropriate syntax */ ada_value_print_inner, /* la_value_print_inner */ - ada_value_print, /* Print a top-level value */ NULL, /* name_of_this */ true, /* la_store_sym_names_in_linkage_form_p */ ada_lookup_symbol_nonlocal, /* Looking up non-local symbols. */ @@ -14101,6 +14100,14 @@ public: (xstrprintf ("{%s} %s", name.c_str (), core_addr_to_string (addr))); } + /* See language.h. */ + + void value_print (struct value *val, struct ui_file *stream, + const struct value_print_options *options) const override + { + return ada_value_print (val, stream, options); + } + protected: /* See language.h. */ diff --git a/gdb/c-lang.c b/gdb/c-lang.c index 42141e28dd..6aa05a6311 100644 --- a/gdb/c-lang.c +++ b/gdb/c-lang.c @@ -896,7 +896,6 @@ extern const struct language_data c_language_data = c_emit_char, /* Print a single char */ c_print_typedef, /* Print a typedef using appropriate syntax */ c_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ NULL, /* name_of_this */ true, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ @@ -1007,7 +1006,6 @@ extern const struct language_data cplus_language_data = c_emit_char, /* Print a single char */ c_print_typedef, /* Print a typedef using appropriate syntax */ c_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ "this", /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ cp_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ @@ -1206,7 +1204,6 @@ extern const struct language_data asm_language_data = c_emit_char, /* Print a single char */ c_print_typedef, /* Print a typedef using appropriate syntax */ c_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ NULL, /* name_of_this */ true, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ @@ -1272,7 +1269,6 @@ extern const struct language_data minimal_language_data = c_emit_char, /* Print a single char */ c_print_typedef, /* Print a typedef using appropriate syntax */ c_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ NULL, /* name_of_this */ true, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ diff --git a/gdb/d-lang.c b/gdb/d-lang.c index 001af06a82..553b38de81 100644 --- a/gdb/d-lang.c +++ b/gdb/d-lang.c @@ -150,7 +150,6 @@ extern const struct language_data d_language_data = c_print_typedef, /* Print a typedef using appropriate syntax. */ d_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value. */ "this", false, /* la_store_sym_names_in_linkage_form_p */ d_lookup_symbol_nonlocal, diff --git a/gdb/f-lang.c b/gdb/f-lang.c index e421e5f964..3e2c97c061 100644 --- a/gdb/f-lang.c +++ b/gdb/f-lang.c @@ -571,7 +571,6 @@ extern const struct language_data f_language_data = f_emit_char, /* Function to print a single character */ f_print_typedef, /* Print a typedef using appropriate syntax */ f_value_print_innner, /* la_value_print_inner */ - c_value_print, /* FIXME */ NULL, /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ cp_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ diff --git a/gdb/go-lang.c b/gdb/go-lang.c index 5e742d7109..14d63ab7e8 100644 --- a/gdb/go-lang.c +++ b/gdb/go-lang.c @@ -535,7 +535,6 @@ extern const struct language_data go_language_data = c_print_typedef, /* Print a typedef using appropriate syntax. */ go_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value. */ NULL, /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, diff --git a/gdb/language.c b/gdb/language.c index 6320577add..5b47a4956e 100644 --- a/gdb/language.c +++ b/gdb/language.c @@ -57,9 +57,6 @@ static void unk_lang_emit_char (int c, struct type *type, static void unk_lang_printchar (int c, struct type *type, struct ui_file *stream); -static void unk_lang_value_print (struct value *, struct ui_file *, - const struct value_print_options *); - /* The current (default at startup) state of type and range checking. (If the modes are set to "auto", though, these are changed based on the default language at startup, and then again based on the @@ -635,6 +632,15 @@ language_defn::watch_location_expression (struct type *type, (xstrprintf ("* (%s *) %s", name.c_str (), core_addr_to_string (addr))); } +/* See language.h. */ + +void +language_defn::value_print (struct value *val, struct ui_file *stream, + const struct value_print_options *options) const +{ + return c_value_print (val, stream, options); +} + /* The default implementation of the get_symbol_name_matcher_inner method from the language_defn class. Matches with strncmp_iw. */ @@ -742,14 +748,6 @@ unk_lang_value_print_inner (struct value *val, "function unk_lang_value_print_inner called.")); } -static void -unk_lang_value_print (struct value *val, struct ui_file *stream, - const struct value_print_options *options) -{ - error (_("internal error - unimplemented " - "function unk_lang_value_print called.")); -} - static const struct op_print unk_op_print_tab[] = { {NULL, OP_NULL, PREC_NULL, 0} @@ -785,7 +783,6 @@ extern const struct language_data unknown_language_data = unk_lang_emit_char, default_print_typedef, /* Print a typedef using appropriate syntax */ unk_lang_value_print_inner, /* la_value_print_inner */ - unk_lang_value_print, /* Print a top-level value */ "this", /* name_of_this */ true, /* store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ @@ -829,6 +826,14 @@ public: /* The unknown language just uses the C++ demangler. */ return gdb_demangle (mangled, options); } + + /* See language.h. */ + + void value_print (struct value *val, struct ui_file *stream, + const struct value_print_options *options) const override + { + error (_("unimplemented unknown_language::value_print called")); + } }; /* Single instance of the unknown language class. */ @@ -855,7 +860,6 @@ extern const struct language_data auto_language_data = unk_lang_emit_char, default_print_typedef, /* Print a typedef using appropriate syntax */ unk_lang_value_print_inner, /* la_value_print_inner */ - unk_lang_value_print, /* Print a top-level value */ "this", /* name_of_this */ false, /* store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ @@ -899,6 +903,14 @@ public: /* The auto language just uses the C++ demangler. */ return gdb_demangle (mangled, options); } + + /* See language.h. */ + + void value_print (struct value *val, struct ui_file *stream, + const struct value_print_options *options) const override + { + error (_("unimplemented auto_language::value_print called")); + } }; /* Single instance of the fake "auto" language. */ diff --git a/gdb/language.h b/gdb/language.h index 1cd3785ab0..4b27c010b0 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -265,11 +265,6 @@ struct language_data int recurse, const struct value_print_options *); - /* Print a top-level value using syntax appropriate for this language. */ - - void (*la_value_print) (struct value *, struct ui_file *, - const struct value_print_options *); - /* Now come some hooks for lookup_symbol. */ /* If this is non-NULL, specifies the name that of the implicit @@ -543,6 +538,10 @@ struct language_defn : language_data /* List of all known languages. */ static const struct language_defn *languages[nr_languages]; + /* Print a top-level value using syntax appropriate for this language. */ + virtual void value_print (struct value *val, struct ui_file *stream, + const struct value_print_options *options) const; + protected: /* This is the overridable part of the GET_SYMBOL_NAME_MATCHER method. @@ -642,7 +641,7 @@ extern enum language set_language (enum language); (current_language->la_print_typedef(type,new_symbol,stream)) #define LA_VALUE_PRINT(val,stream,options) \ - (current_language->la_value_print(val,stream,options)) + (current_language->value_print (val,stream,options)) #define LA_PRINT_CHAR(ch, type, stream) \ (current_language->la_printchar(ch, type, stream)) diff --git a/gdb/m2-lang.c b/gdb/m2-lang.c index 6dbc48767d..615c2f95bd 100644 --- a/gdb/m2-lang.c +++ b/gdb/m2-lang.c @@ -369,7 +369,6 @@ extern const struct language_data m2_language_data = m2_emit_char, /* Function to print a single character */ m2_print_typedef, /* Print a typedef using appropriate syntax */ m2_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ NULL, /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ diff --git a/gdb/objc-lang.c b/gdb/objc-lang.c index fa5aa9bc06..aa9d1a9312 100644 --- a/gdb/objc-lang.c +++ b/gdb/objc-lang.c @@ -344,7 +344,6 @@ extern const struct language_data objc_language_data = c_emit_char, c_print_typedef, /* Print a typedef using appropriate syntax */ c_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ "self", /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c index 4cdfc045e0..1b7553dde6 100644 --- a/gdb/opencl-lang.c +++ b/gdb/opencl-lang.c @@ -1023,7 +1023,6 @@ extern const struct language_data opencl_language_data = c_emit_char, /* Print a single char */ c_print_typedef, /* Print a typedef using appropriate syntax */ c_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ NULL, /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ diff --git a/gdb/p-lang.c b/gdb/p-lang.c index 808e9e51a2..ff3ba3b56e 100644 --- a/gdb/p-lang.c +++ b/gdb/p-lang.c @@ -400,7 +400,6 @@ extern const struct language_data pascal_language_data = pascal_emit_char, /* Print a single char */ pascal_print_typedef, /* Print a typedef using appropriate syntax */ pascal_value_print_inner, /* la_value_print_inner */ - pascal_value_print, /* Print a top-level value */ "this", /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ @@ -478,6 +477,14 @@ public: { pascal_print_type (type, varstring, stream, show, level, flags); } + + /* See language.h. */ + + void value_print (struct value *val, struct ui_file *stream, + const struct value_print_options *options) const override + { + return pascal_value_print (val, stream, options); + } }; /* Single instance of the Pascal language class. */ diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c index fec68e3819..e48be115af 100644 --- a/gdb/rust-lang.c +++ b/gdb/rust-lang.c @@ -2041,7 +2041,6 @@ extern const struct language_data rust_language_data = rust_emitchar, /* Print a single char */ rust_print_typedef, /* Print a typedef using appropriate syntax */ rust_value_print_inner, /* la_value_print_inner */ - c_value_print, /* Print a top-level value */ NULL, /* name_of_this */ false, /* la_store_sym_names_in_linkage_form_p */ rust_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */