OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

clear_detail can only be called on TUI source windows 

The clear_detail method can only be called on source windows, so
remove definitions from the base of the class hierarchy, leaving only
a single non-virtual method.

gdb/ChangeLog
2019-08-13  Tom Tromey  <tom@tromey.com>

	* tui/tui-winsource.h (struct tui_source_window_base)
	<clear_detail>: No longer "override".
	* tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
	* tui/tui-regs.c (tui_data_window::clear_detail): Remove.
	* tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
	* tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
	Remove.
	* tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
This commit is contained in:
Tom Tromey 2019-07-05 12:00:06 -06:00
parent 0111684298
commit a3504e9654
7 changed files with 12 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/ChangeLog
View File

@ -1,3 +1,14 @@
2019-08-13 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)
<clear_detail>: No longer "override".
* tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
* tui/tui-regs.c (tui_data_window::clear_detail): Remove.
* tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
* tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
Remove.
* tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2019-08-13 Tom Tromey <tromey@adacore.com>
* tracepoint.c: Don't include readline.h or history.h.

8
gdb/tui/tui-command.c
View File

@ -30,14 +30,6 @@
/* See tui-command.h. */
void
tui_cmd_window::clear_detail ()
{
wmove (handle, 0, 0);
}
/* See tui-command.h. */
void
tui_cmd_window::do_make_visible_with_new_height ()
{

2
gdb/tui/tui-command.h
View File

@ -35,8 +35,6 @@ struct tui_cmd_window : public tui_win_info
DISABLE_COPY_AND_ASSIGN (tui_cmd_window);
void clear_detail () override;
void make_visible (bool visible) override
{
}

3
gdb/tui/tui-data.h
View File

@ -249,9 +249,6 @@ public:
{
}
/* Clear the pertinent detail in the window. */
virtual void clear_detail () = 0;
/* Called after all the TUI windows are refreshed, to let this
window have a chance to update itself further. */
virtual void refresh_all ()

10
gdb/tui/tui-regs.c
View File

@ -520,16 +520,6 @@ tui_data_window::do_scroll_vertical (int num_to_scroll)
/* See tui-regs.h. */
void
tui_data_window::clear_detail ()
{
regs_content.clear ();
regs_column_count = 1;
display_regs = false;
}
/* See tui-regs.h. */
void
tui_data_window::set_new_height (int height)
{

1
gdb/tui/tui-regs.h
View File

@ -53,7 +53,6 @@ struct tui_data_window : public tui_win_info
DISABLE_COPY_AND_ASSIGN (tui_data_window);
void clear_detail () override;
void refresh_all () override;
void set_new_height (int height) override;

2
gdb/tui/tui-winsource.h
View File

@ -67,7 +67,7 @@ protected:
public:
void clear_detail () override;
void clear_detail ();
void make_visible (bool visible) override;
void refresh_window () override;