OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix alignment for the first section frag on xtensa

Browse Source 
Linking object files produced by partial linking with link-time
relaxation enabled sometimes fails with the following error message:

dangerous relocation: call8: misaligned call target: (.text.unlikely+0x63)

This happens because no basic block with an XTENSA_PROP_ALIGN flag in the
property table is generated for the first basic block, even if the
.align directive is present.
It was believed that the first frag alignment could be derived from the
section alignment, but this was not implemented for the partial linking
case: after partial linking first frag of a section may become not
first, but no additional alignment frag is inserted before it.
Basic block for such frag may be merged with previous basic block into
extended basic block during relaxation pass losing its alignment
restrictions.

Fix this by always recording alignment for the first section frag.

2014-04-22  Max Filippov  <jcmvbkbc@gmail.com>

gas/
    * config/tc-xtensa.c (xtensa_handle_align): record alignment for the
    first section frag.

gas/testsuite/
    * gas/xtensa/all.exp: Add test for the first section frag alignment.
    * gas/xtensa/first_frag_align.d: First section frag alignment expected
    dump.
    * gas/xtensa/first_frag_align.s: First section frag alignment test
    source.
This commit is contained in:
Max Filippov 2014-04-15 19:12:46 +04:00
parent 483805cf9e
commit a35d5e823f
6 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2014-04-22 Max Filippov <jcmvbkbc@gmail.com>
* config/tc-xtensa.c (xtensa_handle_align): record alignment for the
first section frag.
2014-04-22 Christian Svensson <blue@cmd.nu>
* Makefile.am: Remove openrisc and or32 support. Add support for or1k.

1
gas/config/tc-xtensa.c
View File

@ -5609,7 +5609,6 @@ xtensa_handle_align (fragS *fragP)
&& ! fragP->tc_frag_data.is_literal
&& (fragP->fr_type == rs_align
|| fragP->fr_type == rs_align_code)
&& fragP->fr_address + fragP->fr_fix > 0
&& fragP->fr_offset > 0
&& now_seg != bss_section)
{

8
gas/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2014-04-22 Max Filippov <jcmvbkbc@gmail.com>
* gas/xtensa/all.exp: Add test for the first section frag alignment.
* gas/xtensa/first_frag_align.d: First section frag alignment expected
dump.
* gas/xtensa/first_frag_align.s: First section frag alignment test
source.
2014-04-22 Christian Svensson <blue@cmd.nu>
* Makefile.am: Remove openrisc and or32 support. Add support for or1k.

1
gas/testsuite/gas/xtensa/all.exp
View File

@ -99,6 +99,7 @@ if [istarget xtensa*-*-*] then {
run_dump_test "weak-call"
run_dump_test "jlong"
run_dump_test "trampoline"
run_dump_test "first_frag_align"
}
if [info exists errorInfo] then {

9
gas/testsuite/gas/xtensa/first_frag_align.d Normal file
View File

@ -0,0 +1,9 @@
#as:
#objdump: -s
#name: record alignment for the first section frag
.*: +file format .*xtensa.*
#...
Contents of section .xt.prop:
0000 00000000 00000000 00002804 .*
#...

5
gas/testsuite/gas/xtensa/first_frag_align.s Normal file
View File

@ -0,0 +1,5 @@
.text
.align 4
f1:
entry a1, 32
retw