OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[gdb/testsuite] Emit unresolved for unknown proc

Browse Source 
Since commit 26783bce15 "[gdb/testsuite] Don't abort testrun for invalid
command in test-case" we don't abort the testrun when encountering an invalid
command.  However, since we don't report errors in the summary, there's a
chance that the error goes unnoticed.

Make the invalid command error more visible by marking the test-case
unresolved, such that we have f.i.:
...
PASS: gdb.python/py-breakpoint.exp: test_bkpt_internal: Test watchpoint write
UNRESOLVED: gdb.python/py-breakpoint.exp: test_bkpt_eval_funcs: \
  testcase aborted due to invalid command name: gdb_py_test_multiple
ERROR: tcl error sourcing py-breakpoint.exp.
ERROR: invalid command name "gdb_py_test_multiple"
    while executing
  ...
                === gdb Summary ===

nr of expected passes            56
nr of unresolved testcases       1
...

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-06-29  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (unknown): Make test-case unresolved.
This commit is contained in:
Tom de Vries 2020-06-29 13:59:19 +02:00
parent f638ed7301
commit a3ca48cdda
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2020-06-29 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (unknown): Make test-case unresolved.
2020-06-29 Tom de Vries <tdevries@suse.de>
PR gdb/25475

2
gdb/testsuite/lib/gdb.exp
View File

@ -5103,6 +5103,8 @@ proc default_gdb_init { test_file_name } {
rename ::unknown ::dejagnu_unknown
proc unknown { args } {
# Use tcl's unknown.
set cmd [lindex $args 0]
unresolved "testcase aborted due to invalid command name: $cmd"
return [uplevel 1 ::gdb_tcl_unknown $args]
}
}