OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove a use of target_read_string

Browse Source 
linux-tdep.c:dump_mapping_p uses target_read_string, but in a way that
does not really make sense.  It's better to use target_read_memory
here.

gdb/ChangeLog
2020-06-15  Tom Tromey  <tromey@adacore.com>

	* linux-tdep.c (dump_mapping_p): Use target_read_memory.
This commit is contained in:
Tom Tromey 2020-06-15 06:28:09 -06:00
parent 670e35fad9
commit a5d871ddaf
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2020-06-15 Tom Tromey <tromey@adacore.com>
* linux-tdep.c (dump_mapping_p): Use target_read_memory.
2020-06-15 Tom Tromey <tromey@adacore.com>
* valprint.c (read_string): Update comment.

12
gdb/linux-tdep.c
View File

@ -701,22 +701,16 @@ dump_mapping_p (filter_flags filterflags, const struct smaps_vmflags *v,
if (!dump_p && private_p && offset == 0
&& (filterflags & COREFILTER_ELF_HEADERS) != 0)
{
/* Let's check if we have an ELF header. */
gdb::unique_xmalloc_ptr<char> header;
int errcode;
/* Useful define specifying the size of the ELF magical
header. */
#ifndef SELFMAG
#define SELFMAG 4
#endif
/* Read the first SELFMAG bytes and check if it is ELFMAG. */
if (target_read_string (addr, &header, SELFMAG, &errcode) == SELFMAG
&& errcode == 0)
/* Let's check if we have an ELF header. */
gdb_byte h[SELFMAG];
if (target_read_memory (addr, h, SELFMAG) == 0)
{
const char *h = header.get ();
/* The EI_MAG* and ELFMAG* constants come from
<elf/common.h>. */
if (h[EI_MAG0] == ELFMAG0 && h[EI_MAG1] == ELFMAG1