OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Cleanup value_fetch_lazy's comment and return value 

The comment for value_fetch_lazy seems outdated. It says that it's only
called from the value_contents and value_contents_all (macros!), which
is not true.  Also, the return value seems useless now, despite what the
comment says.

gdb/ChangeLog:

	* value.c (value_fetch_lazy): Update comment, change return
	value to void.
	* value.h (value_fetch_lazy): Change return value to void.
This commit is contained in:
Simon Marchi 2015-07-06 13:04:11 -04:00
parent f41cbf58f4
commit a844296a98
3 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2015-07-06 Simon Marchi <simon.marchi@ericsson.com>
* value.c (value_fetch_lazy): Update comment, change return
value to void.
* value.h (value_fetch_lazy): Change return value to void.
2015-07-06 Andrew Burgess <andrew.burgess@embecosm.com> 2015-07-06 Andrew Burgess <andrew.burgess@embecosm.com>
* tui/tui-data.c (tui_partial_win_by_name): Window name is const. * tui/tui-data.c (tui_partial_win_by_name): Window name is const.

17
gdb/value.c
View File

@ -3781,21 +3781,15 @@ value_initialized (struct value *val)
return val->initialized; return val->initialized;
} }
/* Called only from the value_contents and value_contents_all() /* Load the actual content of a lazy value. Fetch the data from the
macros, if the current data for a variable needs to be loaded into user's process and clear the lazy flag to indicate that the data in
value_contents(VAL). Fetches the data from the user's process, and the buffer is valid.
clears the lazy flag to indicate that the data in the buffer is
valid.
If the value is zero-length, we avoid calling read_memory, which If the value is zero-length, we avoid calling read_memory, which
would abort. We mark the value as fetched anyway -- all 0 bytes of would abort. We mark the value as fetched anyway -- all 0 bytes of
it. it. */
This function returns a value because it is used in the void
value_contents macro as part of an expression, where a void would
not work. The value is ignored. */
int
value_fetch_lazy (struct value *val) value_fetch_lazy (struct value *val)
{ {
gdb_assert (value_lazy (val)); gdb_assert (value_lazy (val));
@ -3947,7 +3941,6 @@ value_fetch_lazy (struct value *val)
internal_error (__FILE__, __LINE__, _("Unexpected lazy value type.")); internal_error (__FILE__, __LINE__, _("Unexpected lazy value type."));
set_value_lazy (val, 0); set_value_lazy (val, 0);
return 0;
} }
/* Implementation of the convenience function $_isvoid. */ /* Implementation of the convenience function $_isvoid. */

2
gdb/value.h
View File

@ -361,7 +361,7 @@ extern const gdb_byte *value_contents_for_printing (struct value *value);
extern const gdb_byte * extern const gdb_byte *
value_contents_for_printing_const (const struct value *value); value_contents_for_printing_const (const struct value *value);
extern int value_fetch_lazy (struct value *val); extern void value_fetch_lazy (struct value *val);
/* If nonzero, this is the value of a variable which does not actually /* If nonzero, this is the value of a variable which does not actually
exist in the program, at least partially. If the value is lazy, exist in the program, at least partially. If the value is lazy,