OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix regression 'info variables' does not show minimal symbols. 

12615cba84 Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args to info [args|functions|locals|variables]
introduced a regression that minimal symbols were not listed anymore, due to a wrong
condition checking the absence of a type regexp in the loop scanning the minimal symbols.

Instead, before entering the loop scanning the minimal symbols, check that we
do not have a type regexp, as we will never match a minimal symbol with
this type regexp.

With the fix in this patch, for this part of the code, we basically go back
to the GDB 8.2 logic, with just the addition of
  && !treg.has_value ())
to 'enter' in the minsym case.
This should ensure that at least there is no regression compared to 8.2,
when not using the new type matching argument, as there was no treg in 8.2.

2018-11-20  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* symtab.c (search_symbols): Properly check absence of type regexp
	before entering the loop scanning the minimal symbols.
This commit is contained in:
Philippe Waroquiers 2018-10-30 21:20:52 +01:00
parent 4399bce99b
commit a8462bbf0b
2 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2018-11-20 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* symtab.c (search_symbols): Properly check absence of type regexp
before entering the loop scanning the minimal symbols.
2018-11-20 John Darrington <john@darrington.wattle.id.au>
* s12z-tdep.c (s12z_extract_return_value): New function.

17
gdb/symtab.c
View File

@ -4544,9 +4544,12 @@ search_symbols (const char *regexp, enum search_domain kind,
sort_search_symbols_remove_dups (&result);
/* If there are no eyes, avoid all contact. I mean, if there are
no debug symbols, then add matching minsyms. */
no debug symbols, then add matching minsyms. But if the user wants
to see symbols matching a type regexp, then never give a minimal symbol,
as we assume that a minimal symbol does not have a type. */
if (found_misc || (nfiles == 0 && kind != FUNCTIONS_DOMAIN))
if ((found_misc || (nfiles == 0 && kind != FUNCTIONS_DOMAIN))
&& !treg.has_value ())
{
ALL_MSYMBOLS (objfile, msymbol)
{
@ -4560,13 +4563,9 @@ search_symbols (const char *regexp, enum search_domain kind,
|| MSYMBOL_TYPE (msymbol) == ourtype3
|| MSYMBOL_TYPE (msymbol) == ourtype4)
{
/* If the user wants to see var matching a type regexp,
then never give a minimal symbol. */
if (kind != VARIABLES_DOMAIN
&& !treg.has_value () /* minimal symbol has never a type ???? */
&& (!preg.has_value ()
|| preg->exec (MSYMBOL_NATURAL_NAME (msymbol), 0,
NULL, 0) == 0))
if (!preg.has_value ()
|| preg->exec (MSYMBOL_NATURAL_NAME (msymbol), 0,
NULL, 0) == 0)
{
/* For functions we can do a quick check of whether the
symbol might be found via find_pc_symtab. */