OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: Remove whitespace in 'std::vector <...>'

Browse Source 
In the following 3 commits:

    commit df07e2c772dab40d268dc44c78bb087c4b75b3c6
    Date:   Wed Sep 25 16:10:50 2019 +0100

        gdb: Remove a use of VEC from dwarf2read.{c,h}

    commit 554ac434b02465f1fc925b0ae3393fb841e0d59c
    Date:   Thu Sep 19 13:17:59 2019 -0400

        gdb: Change a VEC to std::vector in btrace.{c,h}

    commit 46f29a9a260da1a03176682aff63bad03d8f2e8b
    Date:   Mon Sep 16 09:12:27 2019 -0400

        gdb: Remove a VEC from gdbsupport/btrace-common.h

I incorrectly wrote 'std::vector <...>' instead of 'std::vector<...>',
this commit fixes this mistake.  There should be no user visible
changes after this commit.

gdb/ChangeLog:

	* btrace.c (btrace_add_pc): Remove whitespace before the template
	parameter in 'std::vector <...>'.
	(parse_xml_btrace_block): Likewise.
	(btrace_maint_decode_pt): Likewise.
	(btrace_maint_update_packets): Likewise.
	(btrace_maint_print_packets): Likewise.
	* btrace.h (struct btrace_maint_info): Likewise.
	* dwarf2read.c (struct type_unit_group): Likewise.
	(build_type_psymtabs_reader): Likewise.
	* gdbsupport/btrace-common.c (btrace_data_append): Likewise.
	* gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
	* nat/linux-btrace.c (perf_event_read_bts): Likewise.
This commit is contained in:
Andrew Burgess 2019-10-02 22:01:46 +01:00
parent 4d825eab2d
commit a8b3b8e93e
7 changed files with 28 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gdb/ChangeLog
View File

@ -1,3 +1,18 @@
2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
* btrace.c (btrace_add_pc): Remove whitespace before the template
parameter in 'std::vector <...>'.
(parse_xml_btrace_block): Likewise.
(btrace_maint_decode_pt): Likewise.
(btrace_maint_update_packets): Likewise.
(btrace_maint_print_packets): Likewise.
* btrace.h (struct btrace_maint_info): Likewise.
* dwarf2read.c (struct type_unit_group): Likewise.
(build_type_psymtabs_reader): Likewise.
* gdbsupport/btrace-common.c (btrace_data_append): Likewise.
* gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
* nat/linux-btrace.c (perf_event_read_bts): Likewise.
2019-10-03 Tom de Vries <tdevries@suse.de>
* cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of

12
gdb/btrace.c
View File

@ -1579,7 +1579,7 @@ btrace_add_pc (struct thread_info *tp)
pc = regcache_read_pc (regcache);
btrace.format = BTRACE_FORMAT_BTS;
btrace.variant.bts.blocks = new std::vector <btrace_block>;
btrace.variant.bts.blocks = new std::vector<btrace_block>;
btrace.variant.bts.blocks->emplace_back (pc, pc);
@ -2036,7 +2036,7 @@ parse_xml_btrace_block (struct gdb_xml_parser *parser,
case BTRACE_FORMAT_NONE:
btrace->format = BTRACE_FORMAT_BTS;
btrace->variant.bts.blocks = new std::vector <btrace_block>;
btrace->variant.bts.blocks = new std::vector<btrace_block>;
break;
default:
@ -2963,7 +2963,7 @@ btrace_maint_decode_pt (struct btrace_maint_info *maint,
int errcode;
if (maint->variant.pt.packets == NULL)
maint->variant.pt.packets = new std::vector <btrace_pt_packet>;
maint->variant.pt.packets = new std::vector<btrace_pt_packet>;
for (;;)
{
@ -3095,7 +3095,7 @@ btrace_maint_update_packets (struct btrace_thread_info *btinfo,
#if defined (HAVE_LIBIPT)
case BTRACE_FORMAT_PT:
if (btinfo->maint.variant.pt.packets == nullptr)
btinfo->maint.variant.pt.packets = new std::vector <btrace_pt_packet>;
btinfo->maint.variant.pt.packets = new std::vector<btrace_pt_packet>;
if (btinfo->maint.variant.pt.packets->empty ())
btrace_maint_update_pt_packets (btinfo);
@ -3123,7 +3123,7 @@ btrace_maint_print_packets (struct btrace_thread_info *btinfo,
case BTRACE_FORMAT_BTS:
{
const std::vector <btrace_block> &blocks
const std::vector<btrace_block> &blocks
= *btinfo->data.variant.bts.blocks;
unsigned int blk;
@ -3144,7 +3144,7 @@ btrace_maint_print_packets (struct btrace_thread_info *btinfo,
#if defined (HAVE_LIBIPT)
case BTRACE_FORMAT_PT:
{
const std::vector <btrace_pt_packet> &packets
const std::vector<btrace_pt_packet> &packets
= *btinfo->maint.variant.pt.packets;
unsigned int pkt;

2
gdb/btrace.h
View File

@ -297,7 +297,7 @@ struct btrace_maint_info
struct
{
/* A vector of decoded packets. */
std::vector <btrace_pt_packet> *packets;
std::vector<btrace_pt_packet> *packets;
/* The packet history iterator.
We are iterating over the above PACKETS vector. */

4
gdb/dwarf2read.c
View File

@ -620,7 +620,7 @@ struct type_unit_group
/* The TUs that share this DW_AT_stmt_list entry.
This is added to while parsing type units to build partial symtabs,
and is deleted afterwards and not used again. */
std::vector <signatured_type *> *tus;
std::vector<signatured_type *> *tus;
/* The compunit symtab.
Type units in a group needn't all be defined in the same source file,
@ -8191,7 +8191,7 @@ build_type_psymtabs_reader (const struct die_reader_specs *reader,
tu_group = get_type_unit_group (cu, attr);
if (tu_group->tus == nullptr)
tu_group->tus = new std::vector <signatured_type *>;
tu_group->tus = new std::vector<signatured_type *>;
tu_group->tus->push_back (sig_type);
prepare_one_comp_unit (cu, type_unit_die, language_minimal);

2
gdb/gdbsupport/btrace-common.c
View File

@ -133,7 +133,7 @@ btrace_data_append (struct btrace_data *dst,
case BTRACE_FORMAT_NONE:
dst->format = BTRACE_FORMAT_BTS;
dst->variant.bts.blocks = new std::vector <btrace_block>;
dst->variant.bts.blocks = new std::vector<btrace_block>;
/* Fall-through. */
case BTRACE_FORMAT_BTS:

2
gdb/gdbsupport/btrace-common.h
View File

@ -141,7 +141,7 @@ struct btrace_data_bts
/* Branch trace is represented as a vector of branch trace blocks starting
with the most recent block. This needs to be a pointer as we place
btrace_data_bts into a union. */
std::vector <btrace_block> *blocks;
std::vector<btrace_block> *blocks;
};
/* Configuration information to go with the trace data. */

4
gdb/nat/linux-btrace.c
View File

@ -271,11 +271,11 @@ perf_event_sample_ok (const struct perf_event_sample *sample)
In case the buffer overflows during sampling, one sample may have its lower
part at the end and its upper part at the beginning of the buffer. */
static std::vector <btrace_block> *
static std::vector<btrace_block> *
perf_event_read_bts (struct btrace_target_info* tinfo, const uint8_t *begin,
const uint8_t *end, const uint8_t *start, size_t size)
{
std::vector <btrace_block> *btrace = new std::vector <btrace_block>;
std::vector<btrace_block> *btrace = new std::vector<btrace_block>;
struct perf_event_sample sample;
size_t read = 0;
struct btrace_block block = { 0, 0 };