OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

x86/Intel: drop pointless suffix setting for "tbyte ptr" 

There are extremely few insns accepting "tbyte ptr" operand, so the
"tbyte" operand flag checking done by match_operand_size() is already
sufficient; the setting of the suffix has become meaningless anyway
with dc2be329b9 ("i386: Only check suffix in instruction mnemonic").
Fold the code with that setting the "byte" operand flag to force an
error (no insn at all accepts both "byte ptr" and tbyte ptr" operands,
except for AnySize ones where the two (conflicting) recorded types
don't matter (operand_size_match() doesn't call match_operand_size() in
this case).
This commit is contained in:
Jan Beulich 2019-12-09 13:29:44 +01:00
parent 4cbda994e6
commit a8f4f6b9bc
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gas/ChangeLog
View File

@ -1,3 +1,9 @@
2019-12-09 Jan Beulich <jbeulich@suse.com>
* config/tc-i386-intel.c (i386_intel_operand): Set "byte"
attribute suffix instead of suffix uniformly for insns not
possibly accepting "tbyte ptr" explicitly.
2019-12-09 Jan Beulich <jbeulich@suse.com>
* config/tc-i386-intel.c (i386_intel_operand): Don't set suffix

15
gas/config/tc-i386-intel.c
View File

@ -691,17 +691,12 @@ i386_intel_operand (char *operand_string, int got_a_float)
i.types[this_operand].bitfield.tbyte = 1;
if (got_a_float == 1)
suffix = LONG_DOUBLE_MNEM_SUFFIX;
else if (current_templates->start->operand_types[0].bitfield.fword
|| current_templates->start->operand_types[0].bitfield.tbyte)
{
/* l[defgs]s, [ls][gi]dt */
if (flag_code == CODE_64BIT)
suffix = QWORD_MNEM_SUFFIX;
else
i.types[this_operand].bitfield.byte = 1; /* cause an error */
}
else if ((current_templates->start->operand_types[0].bitfield.fword
|| current_templates->start->operand_types[0].bitfield.tbyte)
&& flag_code == CODE_64BIT)
suffix = QWORD_MNEM_SUFFIX; /* l[fgs]s, [ls][gi]dt */
else
suffix = BYTE_MNEM_SUFFIX; /* so it will cause an error */
i.types[this_operand].bitfield.byte = 1; /* cause an error */
break;
case O_oword_ptr: