OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rename flag_size_check to flag_allow_nonconst_size and make it a bool 

This name describes what the variable means slightly better, and the enum with
two values that is only used for this one variable is kind of silly.

gas/ChangeLog:

2016-03-25  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* as.c (parse_args): Adjust.
	* as.h (flag_size_check): Rename to flag_allow_nonconst_size.
	* config/obj-elf.c (elf_frob_symbol): Adjust.
This commit is contained in:
Trevor Saunders 2016-03-25 15:43:13 -04:00
parent 099b880550
commit a90fb5e33b
4 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gas/ChangeLog
View File

@ -1,3 +1,9 @@
2016-03-25 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* as.c (parse_args): Adjust.
* as.h (flag_size_check): Rename to flag_allow_nonconst_size.
* config/obj-elf.c (elf_frob_symbol): Adjust.
2016-03-24 Jose E. Marchesi <jose.marchesi@oracle.com>
* config/tc-sparc.c (sparc_ip): Remove the V9 restriction on ASR

4
gas/as.c
View File

@ -870,9 +870,9 @@ This program has absolutely no warranty.\n"));
case OPTION_SIZE_CHECK:
if (strcasecmp (optarg, "error") == 0)
flag_size_check = size_check_error;
flag_allow_nonconst_size = FALSE;
else if (strcasecmp (optarg, "warning") == 0)
flag_size_check = size_check_warning;
flag_allow_nonconst_size = TRUE;
else
as_fatal (_("Invalid --size-check= option: `%s'"), optarg);
break;

7
gas/as.h
View File

@ -585,12 +585,7 @@ COMMON const char * found_comment_file;
#if defined OBJ_ELF || defined OBJ_MAYBE_ELF
/* If .size directive failure should be error or warning. */
COMMON enum
{
size_check_error = 0,
size_check_warning
}
flag_size_check;
COMMON int flag_allow_nonconst_size;
/* If we should generate ELF common symbols with the STT_COMMON type. */
extern int flag_use_elf_stt_common;

2
gas/config/obj-elf.c
View File

@ -2165,7 +2165,7 @@ elf_frob_symbol (symbolS *symp, int *puntp)
S_SET_SIZE (symp, size->X_add_number);
else
{
if (flag_size_check == size_check_error)
if (!flag_allow_nonconst_size)
as_bad (_(".size expression for %s "
"does not evaluate to a constant"), S_GET_NAME (symp));
else