From a9f26f609e3a1b6ae3aab300b55442e0a81e2bce Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 22 Nov 2017 12:22:11 +0000 Subject: [PATCH] Fix build with GCC 8: strncpy ->strcpy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Recent gcc 8 trunk emits the warning below, ../../binutils-gdb/gdb/python/py-gdb-readline.c:79:15: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncpy (q, p, n); ~~~~~~~~^~~~~~~~~ ../../binutils-gdb/gdb/python/py-gdb-readline.c:73:14: note: length computed here n = strlen (p); ~~~~~~~^~~ gdb: 2017-11-22 Yao Qi * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy. --- gdb/ChangeLog | 4 ++++ gdb/python/py-gdb-readline.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a9e7528a87..63ae72e59f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-11-22 Yao Qi + + * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy. + 2017-11-22 Yao Qi * cli/cli-decode.c (help_list): Use memcpy instead of strncpy. diff --git a/gdb/python/py-gdb-readline.c b/gdb/python/py-gdb-readline.c index a02fa8ce6f..ab14b8c8e8 100644 --- a/gdb/python/py-gdb-readline.c +++ b/gdb/python/py-gdb-readline.c @@ -76,7 +76,7 @@ gdbpy_readline_wrapper (FILE *sys_stdin, FILE *sys_stdout, q = (char *) PyMem_RawMalloc (n + 2); if (q != NULL) { - strncpy (q, p, n); + strcpy (q, p); q[n] = '\n'; q[n + 1] = '\0'; }