OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use gdbarch obstack to allocate the TYPE_NAME string in arch_type 

Since the type whose name is being set is now being allocated on the
gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
This reduces the number of individual valgrind warnings for the command
"gdb gdb" from ~300 to ~150.

Tested on x86_64-unknown-linux-gnu.

gdb/ChangeLog:

	* gdbarch.h (gdbarch_obstack_strdup): Declare.
	* gdbarch.c (gdbarch_obstack_strdup): Define.
	* gdbtypes.c (arch_type): Use it.
This commit is contained in:
Patrick Palka 2015-06-29 10:45:47 -04:00
parent 8f57eec2fb
commit aa78b3b28a
4 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2015-08-29 Patrick Palka <patrick@parcs.ath.cx>
* gdbarch.h (gdbarch_obstack_strdup): Declare.
* gdbarch.c (gdbarch_obstack_strdup): Define.
* gdbtypes.c (arch_type): Use it.
2015-08-29 Patrick Palka <patrick@parcs.ath.cx>
* gdbtypes.c (alloc_type_arch): Allocate the type on the given

10
gdb/gdbarch.c
View File

@ -449,6 +449,16 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size)
return data;
}
/* See gdbarch.h. */
char *
gdbarch_obstack_strdup (struct gdbarch *gdbarch, const char *string)
{
char *obstring = gdbarch_obstack_zalloc (gdbarch, strlen (string) + 1);
strcpy (obstring, string);
return obstring;
}
/* Free a gdbarch struct. This should never happen in normal
operation --- once you've created a gdbarch, you keep it around.

5
gdb/gdbarch.h
View File

@ -1618,6 +1618,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size);
#define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE)))
#define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE)))
/* Duplicate STRING, returning an equivalent string that's allocated on the
obstack associated with GDBARCH. The string is freed when the corresponding
architecture is also freed. */
extern char *gdbarch_obstack_strdup (struct gdbarch *gdbarch, const char *string);
/* Helper function. Force an update of the current architecture.

2
gdb/gdbtypes.c
View File

@ -4549,7 +4549,7 @@ arch_type (struct gdbarch *gdbarch,
TYPE_LENGTH (type) = length;
if (name)
TYPE_NAME (type) = xstrdup (name);
TYPE_NAME (type) = gdbarch_obstack_strdup (gdbarch, name);
return type;
}