Remove FIXME in solib-aix.c:solib_aix_relocate_section_addresses

This issue should now be fixed thanks to a change in bfd removing
the SEC_ALLOC flag from all sections that do not get mapped to
memory.

gdb/ChangeLog:

        * solib-aix.c (solib_aix_relocate_section_addresses):
        Remove FIXME comment.
This commit is contained in:
Joel Brobecker 2013-05-10 13:25:28 +00:00
parent 110a61d342
commit ab1c4e8861
2 changed files with 5 additions and 10 deletions

View File

@ -4,6 +4,11 @@
For the .bss section action, apply the same offset as
the .data section.
2013-05-10 Joel Brobecker <brobecker@adacore.com>
* solib-aix.c (solib_aix_relocate_section_addresses):
Remove FIXME comment.
2013-05-10 Joel Brobecker <brobecker@adacore.com>
PR tdep/15420:

View File

@ -432,16 +432,6 @@ solib_aix_relocate_section_addresses (struct so_list *so,
else
{
/* All other sections should not be relocated. */
/* FIXME: GDB complains that the .loader section sometimes
overlaps with other sections (Eg: the .data section).
As far as I can tell, the loader section had the LOAD flag
set, but not the RELOC. So it should not be relocated.
There seems to be a problem there, and maybe it has to do
with setting sec->addr to 0 (when the vma is indeed 0).
But even if there wasn't, the problem then becomes the fact
that many shared objects inside shared libraries have
a .loader section whose vma is 0, thus also triggering
an overlap warning. */
sec->addr = bfd_section_vma (abfd, bfd_sect);
sec->endaddr = sec->addr + bfd_section_size (abfd, bfd_sect);
}