From ac88e2de8314efd9aaa9132c5643ecbf715de508 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 12 Sep 2017 21:09:35 -0600 Subject: [PATCH] Constify some commands in remote.c gdb/ChangeLog 2017-09-27 Tom Tromey * remote.c (set_memory_packet_size) (set_memory_write_packet_size, show_memory_write_packet_size) (set_memory_read_packet_size, show_memory_read_packet_size) (compare_sections_command, packet_command, remote_put_command) (remote_get_command, remote_delete_command): Constify. --- gdb/ChangeLog | 8 ++++++++ gdb/remote.c | 24 ++++++++++-------------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 35f4810bf9..37a6635db7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2017-09-27 Tom Tromey + + * remote.c (set_memory_packet_size) + (set_memory_write_packet_size, show_memory_write_packet_size) + (set_memory_read_packet_size, show_memory_read_packet_size) + (compare_sections_command, packet_command, remote_put_command) + (remote_get_command, remote_delete_command): Constify. + 2017-09-27 Tom Tromey * mips-tdep.c (show_mipsfpu_command, set_mipsfpu_single_command) diff --git a/gdb/remote.c b/gdb/remote.c index 33b0c2a09d..d4f06a84da 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -171,10 +171,6 @@ static CORE_ADDR remote_address_masked (CORE_ADDR); static void print_packet (const char *); -static void compare_sections_command (char *, int); - -static void packet_command (char *, int); - static int stub_unpack_int (char *buff, int fieldlength); static ptid_t remote_current_thread (ptid_t oldptid); @@ -1096,7 +1092,7 @@ get_memory_packet_size (struct memory_packet_config *config) something really big then do a sanity check. */ static void -set_memory_packet_size (char *args, struct memory_packet_config *config) +set_memory_packet_size (const char *args, struct memory_packet_config *config) { int fixed_p = config->fixed_p; long size = config->size; @@ -1157,13 +1153,13 @@ static struct memory_packet_config memory_write_packet_config = }; static void -set_memory_write_packet_size (char *args, int from_tty) +set_memory_write_packet_size (const char *args, int from_tty) { set_memory_packet_size (args, &memory_write_packet_config); } static void -show_memory_write_packet_size (char *args, int from_tty) +show_memory_write_packet_size (const char *args, int from_tty) { show_memory_packet_size (&memory_write_packet_config); } @@ -1180,13 +1176,13 @@ static struct memory_packet_config memory_read_packet_config = }; static void -set_memory_read_packet_size (char *args, int from_tty) +set_memory_read_packet_size (const char *args, int from_tty) { set_memory_packet_size (args, &memory_read_packet_config); } static void -show_memory_read_packet_size (char *args, int from_tty) +show_memory_read_packet_size (const char *args, int from_tty) { show_memory_packet_size (&memory_read_packet_config); } @@ -10242,7 +10238,7 @@ remote_verify_memory (struct target_ops *ops, Useful for verifying the image on the target against the exec file. */ static void -compare_sections_command (char *args, int from_tty) +compare_sections_command (const char *args, int from_tty) { asection *s; struct cleanup *old_chain; @@ -10846,7 +10842,7 @@ remote_memory_map (struct target_ops *ops) } static void -packet_command (char *args, int from_tty) +packet_command (const char *args, int from_tty) { struct remote_state *rs = get_remote_state (); @@ -12127,7 +12123,7 @@ remote_file_delete (const char *remote_file, int from_tty) } static void -remote_put_command (char *args, int from_tty) +remote_put_command (const char *args, int from_tty) { if (args == NULL) error_no_arg (_("file to put")); @@ -12140,7 +12136,7 @@ remote_put_command (char *args, int from_tty) } static void -remote_get_command (char *args, int from_tty) +remote_get_command (const char *args, int from_tty) { if (args == NULL) error_no_arg (_("file to get")); @@ -12153,7 +12149,7 @@ remote_get_command (char *args, int from_tty) } static void -remote_delete_command (char *args, int from_tty) +remote_delete_command (const char *args, int from_tty) { if (args == NULL) error_no_arg (_("file to delete"));