PR binutils/16024

* objdump.c (usage): Mark as a no-return function.
	(main): Add comment explaining why a break statement is not
	needed.
This commit is contained in:
Nick Clifton 2013-10-09 16:17:23 +00:00
parent b7b2bb1d1c
commit aebcf7b7ec
2 changed files with 10 additions and 6 deletions

View File

@ -1,5 +1,10 @@
2013-10-09 Nick Clifton <nickc@redhat.com> 2013-10-09 Nick Clifton <nickc@redhat.com>
PR binutils/16024
* objdump.c (usage): Mark as a no-return function.
(main): Add comment explaining why a break statement is not
needed.
* dwarf.c (add64): New function. * dwarf.c (add64): New function.
(read_and_display_attr_value): Add CU offset in to the value (read_and_display_attr_value): Add CU offset in to the value
displayed for a DW_AT_ref8 attribute. displayed for a DW_AT_ref8 attribute.

View File

@ -1,7 +1,5 @@
/* objdump.c -- dump information about an object file. /* objdump.c -- dump information about an object file.
Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, Copyright 1990-2013 Free Software Foundation, Inc.
2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
2012, 2013 Free Software Foundation, Inc.
This file is part of GNU Binutils. This file is part of GNU Binutils.
@ -193,6 +191,7 @@ static const struct objdump_private_desc * const objdump_private_vectors[] =
NULL NULL
}; };
static void usage (FILE *, int) ATTRIBUTE_NORETURN;
static void static void
usage (FILE *stream, int status) usage (FILE *stream, int status)
{ {
@ -3657,15 +3656,15 @@ main (int argc, char **argv)
dump_section_headers = TRUE; dump_section_headers = TRUE;
seenflag = TRUE; seenflag = TRUE;
break; break;
case 'H':
usage (stdout, 0);
seenflag = TRUE;
case 'v': case 'v':
case 'V': case 'V':
show_version = TRUE; show_version = TRUE;
seenflag = TRUE; seenflag = TRUE;
break; break;
case 'H':
usage (stdout, 0);
/* No need to set seenflag or to break - usage() does not return. */
default: default:
usage (stderr, 1); usage (stderr, 1);
} }