Clarify GDBSERVER use in linux-waitpid.c

This commit makes linux-waitpid.c include common-defs.h.  GDB's
inclusion of defs.h is removed, but gdbserver's inclusion of
server.h remains to support some gdbserver-specific debug code
that cannot presently be merged.  A new FIXME documents this.

gdb/ChangeLog:

	* nat/linux-waitpid.c: Include common-defs.h.
	[GDBSERVER]: Add FIXME comment.
	[!GDBSERVER]: Don't include defs.h or signal.h.
	(linux_debug) [!GDBSERVER]: Remove empty block.
This commit is contained in:
Gary Benson 2014-09-12 10:57:46 +01:00
parent 296b1496f7
commit b006a80e5f
2 changed files with 13 additions and 5 deletions

View File

@ -1,3 +1,10 @@
2014-09-12 Gary Benson <gbenson@redhat.com>
* nat/linux-waitpid.c: Include common-defs.h.
[GDBSERVER]: Add FIXME comment.
[!GDBSERVER]: Don't include defs.h or signal.h.
(linux_debug) [!GDBSERVER]: Remove empty block.
2014-09-12 Gary Benson <gbenson@redhat.com>
* nat/x86-dregs.c: Include common-defs.h and break-common.h.

View File

@ -17,11 +17,14 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "common-defs.h"
#ifdef GDBSERVER
/* FIXME: server.h is required for the definition of debug_threads
which is used in the gdbserver-specific debug printing in
linux_debug. This code should be made available to GDB also,
but the lack of a suitable flag to enable it prevents this. */
#include "server.h"
#else
#include "defs.h"
#include "signal.h"
#endif
#include "linux-nat.h"
@ -42,8 +45,6 @@ linux_debug (const char *format, ...)
vfprintf (stderr, format, args);
va_end (args);
}
#else
/* GDB-specific debugging output. */
#endif
}