From b11b1f88bd8c59e136e0ec10fbf5ea7f30d0ded6 Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Wed, 27 Apr 2011 19:52:22 +0000 Subject: [PATCH] gdb/ Format the code for the next patch. * dwarf2read.c (struct mapped_index): Include delimiting newlines. * utils.c (strcmp_iw_ordered): Reformat the code for the next patch. New variables c1 and c2. --- gdb/ChangeLog | 7 ++++ gdb/dwarf2read.c | 5 +++ gdb/utils.c | 85 ++++++++++++++++++++++++++---------------------- 3 files changed, 58 insertions(+), 39 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 403c4cf561..92d01efec4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2011-04-27 Jan Kratochvil + + Format the code for the next patch. + * dwarf2read.c (struct mapped_index): Include delimiting newlines. + * utils.c (strcmp_iw_ordered): Reformat the code for the next patch. + New variables c1 and c2. + 2011-04-27 Ulrich Weigand * infrun.c (proceed): Do not single-step into signal delivery diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index e0a4675d7a..0ca9532f70 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -151,14 +151,19 @@ struct mapped_index { /* The total length of the buffer. */ off_t total_size; + /* A pointer to the address table data. */ const gdb_byte *address_table; + /* Size of the address table data in bytes. */ offset_type address_table_size; + /* The symbol table, implemented as a hash table. */ const offset_type *symbol_table; + /* Size in slots, each slot is 2 offset_types. */ offset_type symbol_table_slots; + /* A pointer to the constant pool. */ const char *constant_pool; }; diff --git a/gdb/utils.c b/gdb/utils.c index 11c34bf7bd..850b80dc1e 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -3023,47 +3023,54 @@ strcmp_iw (const char *string1, const char *string2) int strcmp_iw_ordered (const char *string1, const char *string2) { - while ((*string1 != '\0') && (*string2 != '\0')) + /* Formatting stub. */ + if (1) { - while (isspace (*string1)) - { - string1++; - } - while (isspace (*string2)) - { - string2++; - } - if (*string1 != *string2) - { - break; - } - if (*string1 != '\0') - { - string1++; - string2++; - } - } + /* C1 and C2 are valid only if *string1 != '\0' && *string2 != '\0'. + Provide stub characters if we are already at the end of one of the + strings. */ + char c1 = 'X', c2 = 'X'; - switch (*string1) - { - /* Characters are non-equal unless they're both '\0'; we want to - make sure we get the comparison right according to our - comparison in the cases where one of them is '\0' or '('. */ - case '\0': - if (*string2 == '\0') - return 0; - else - return -1; - case '(': - if (*string2 == '\0') - return 1; - else - return -1; - default: - if (*string2 == '(') - return 1; - else - return *string1 - *string2; + while (*string1 != '\0' && *string2 != '\0') + { + while (isspace (*string1)) + string1++; + while (isspace (*string2)) + string2++; + + c1 = *string1; + c2 = *string2; + if (c1 != c2) + break; + + if (*string1 != '\0') + { + string1++; + string2++; + } + } + + switch (*string1) + { + /* Characters are non-equal unless they're both '\0'; we want to + make sure we get the comparison right according to our + comparison in the cases where one of them is '\0' or '('. */ + case '\0': + if (*string2 == '\0') + return 0; + else + return -1; + case '(': + if (*string2 == '\0') + return 1; + else + return -1; + default: + if (*string2 == '\0' || *string2 == '(') + return 1; + else + return c1 - c2; + } } }