OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* solib-target.c (solib_target_current_sos): Remove 'const' 

qualifier from type of library_document local variable to be
	able to free it and avoid a memory leak.
	Use cleanup chain to avoid leak even if exceptino is generated.
This commit is contained in:
Pierre Muller 2012-12-14 23:27:13 +00:00
parent 774094928e
commit b25d79d436
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2012-12-14 Pierre Muller <muller@sourceware.org>
Pedro Alves <palves@redhat.com>
* solib-target.c (solib_target_current_sos): Remove 'const'
qualifier from type of library_document local variable to be
able to free it and avoid a memory leak.
Use cleanup chain to avoid leak even if exceptino is generated.
2012-12-14 Tom Tromey <tromey@redhat.com>
PR c++/8888:

10
gdb/solib-target.c
View File

@ -246,7 +246,8 @@ static struct so_list *
solib_target_current_sos (void)
{
struct so_list *new_solib, *start = NULL, *last = NULL;
const char *library_document;
char *library_document;
struct cleanup *old_chain;
VEC(lm_info_p) *library_list;
struct lm_info *info;
int ix;
@ -258,8 +259,15 @@ solib_target_current_sos (void)
if (library_document == NULL)
return NULL;
/* solib_target_parse_libraries may throw, so we use a cleanup. */
old_chain = make_cleanup (xfree, library_document);
/* Parse the list. */
library_list = solib_target_parse_libraries (library_document);
/* library_document string is not needed behind this point. */
do_cleanups (old_chain);
if (library_list == NULL)
return NULL;