OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* kod.c (kod_set_os): Revert previous change. Is called by ``info 

set'' and this leads to a core dump.  Move xstrdup of
operating_system to after check that it is not NULL.
This commit is contained in:
Andrew Cagney 2002-03-17 19:29:37 +00:00
parent 8e694ecf16
commit b51450c9ff
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2002-03-17 Andrew Cagney <ac131313@redhat.com>
* kod.c (kod_set_os): Revert previous change. Is called by ``info
set'' and this leads to a core dump. Move xstrdup of
operating_system to after check that it is not NULL.
2002-03-17 Andrew Cagney <ac131313@redhat.com>
* kod.c (kod_set_os): Remove unnecessary check that

12
gdb/kod.c
View File

@ -132,6 +132,15 @@ kod_set_os (char *arg, int from_tty, struct cmd_list_element *command)
{
char *p;
/* NOTE: cagney/2002-03-17: This function gets called by the command
``info set'' with COMMAND pointing to a show_cmd rather than a
set command. This the test below is removed, a core dump results
(think about what happens when OPERATING_SYSTEM is NULL). The
wiered thing is that all other ``set'' handlers don't need this
test. */
if (command->type != set_cmd)
return;
/* If we had already had an open OS, close it. */
if (gdb_kod_close)
(*gdb_kod_close) ();
@ -142,7 +151,6 @@ kod_set_os (char *arg, int from_tty, struct cmd_list_element *command)
delete_cmd (old_operating_system, &infolist);
xfree (old_operating_system);
}
old_operating_system = xstrdup (operating_system);
if (! operating_system || ! *operating_system)
{
@ -157,6 +165,8 @@ kod_set_os (char *arg, int from_tty, struct cmd_list_element *command)
{
char *kodlib;
old_operating_system = xstrdup (operating_system);
load_kod_library (operating_system);
kodlib = (*gdb_kod_open) (gdb_kod_display, gdb_kod_query);