OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add "const" to a few locals in gdb

Browse Source 
I noticed that some code in gdb was doing:

    char *mumble = getenv (...)

However, using "const char *" here would be clearer.
This patch fixes the instances I could readily build.

Tested by rebuilding.

gdb/ChangeLog
2018-09-24  Tom Tromey  <tom@tromey.com>

	* common/pathstuff.c (get_standard_cache_dir): Make
	"xdg_cache_home" and "home" const.
	* top.c (init_history): Make "tmpenv" const.
	* main.c (get_init_files): Make "homedir" const.
This commit is contained in:
Tom Tromey 2018-09-24 06:15:17 -06:00
parent ae778caf09
commit b5a9bfbebe
4 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2018-09-24 Tom Tromey <tom@tromey.com>
* common/pathstuff.c (get_standard_cache_dir): Make
"xdg_cache_home" and "home" const.
* top.c (init_history): Make "tmpenv" const.
* main.c (get_init_files): Make "homedir" const.
2018-09-23 Tom Tromey <tom@tromey.com>
PR python/18852:

4
gdb/common/pathstuff.c
View File

@ -171,7 +171,7 @@ get_standard_cache_dir ()
#endif
#ifndef __APPLE__
char *xdg_cache_home = getenv ("XDG_CACHE_HOME");
const char *xdg_cache_home = getenv ("XDG_CACHE_HOME");
if (xdg_cache_home != NULL)
{
/* Make sure the path is absolute and tilde-expanded. */
@ -180,7 +180,7 @@ get_standard_cache_dir ()
}
#endif
char *home = getenv ("HOME");
const char *home = getenv ("HOME");
if (home != NULL)
{
/* Make sure the path is absolute and tilde-expanded. */

2
gdb/main.c
View File

@ -208,7 +208,7 @@ get_init_files (const char **system_gdbinit,
if (!initialized)
{
struct stat homebuf, cwdbuf, s;
char *homedir;
const char *homedir;
if (SYSTEM_GDBINIT[0])
{

2
gdb/top.c
View File

@ -1846,7 +1846,7 @@ set_verbose (const char *args, int from_tty, struct cmd_list_element *c)
void
init_history (void)
{
char *tmpenv;
const char *tmpenv;
tmpenv = getenv ("GDBHISTSIZE");
if (tmpenv)