OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove EXTERN from buildsym.h

Browse Source 
Nothing in buildsym.h relies on the "EXTERN" method of
declaration/definition, so remove the traces.

gdb/ChangeLog
2018-07-20  Tom Tromey  <tom@tromey.com>

	* buildsym.h (EXTERN): Don't define or undef.
	* buildsym.c (EXTERN): Don't define.
This commit is contained in:
Tom Tromey 2018-05-21 09:21:18 -06:00
parent ddb7060226
commit b80a981d08
3 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2018-07-20 Tom Tromey <tom@tromey.com>
* buildsym.h (EXTERN): Don't define or undef.
* buildsym.c (EXTERN): Don't define.
2018-07-20 Tom Tromey <tom@tromey.com> 2018-07-20 Tom Tromey <tom@tromey.com>
* buildsym.c: Remove TODO comment. * buildsym.c: Remove TODO comment.

7
gdb/buildsym.c
View File

@ -62,6 +62,7 @@
*/ */
#include "defs.h" #include "defs.h"
#include "buildsym.h"
#include "bfd.h" #include "bfd.h"
#include "gdb_obstack.h" #include "gdb_obstack.h"
#include "symtab.h" #include "symtab.h"
@ -79,12 +80,6 @@
#include "addrmap.h" #include "addrmap.h"
#include <algorithm> #include <algorithm>
/* Ask buildsym.h to define the vars it normally declares `extern'. */
#define EXTERN
/**/
#include "buildsym.h" /* Our own declarations. */
#undef EXTERN
/* For cleanup_undefined_stabs_types and finish_global_stabs (somewhat /* For cleanup_undefined_stabs_types and finish_global_stabs (somewhat
questionable--see comment where we call them). */ questionable--see comment where we call them). */

13
gdb/buildsym.h
View File

@ -30,22 +30,13 @@ enum language;
file-reading routines. file-reading routines.
They originated in dbxread.c of gdb-4.2, and were split out to They originated in dbxread.c of gdb-4.2, and were split out to
make xcoffread.c more maintainable by sharing code. make xcoffread.c more maintainable by sharing code. */
Variables declared in this file can be defined by #define-ing the
name EXTERN to null. It is used to declare variables that are
normally extern, but which get defined in a single module using
this technique. */
struct block; struct block;
struct pending_block; struct pending_block;
struct dynamic_prop; struct dynamic_prop;
#ifndef EXTERN
#define EXTERN extern
#endif
/* The list of sub-source-files within the current individual /* The list of sub-source-files within the current individual
compilation. Each file gets its own symtab with its own linetable compilation. Each file gets its own symtab with its own linetable
and associated info, but they all share one blockvector. */ and associated info, but they all share one blockvector. */
@ -271,6 +262,4 @@ extern struct pending **get_file_symbols ();
extern struct pending **get_global_symbols (); extern struct pending **get_global_symbols ();
#undef EXTERN
#endif /* defined (BUILDSYM_H) */ #endif /* defined (BUILDSYM_H) */