OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* remote-fileio.c (remote_fileio_func_read): Limit console

Browse Source 
reads to 16K.
This commit is contained in:
Daniel Jacobowitz 2009-11-12 21:01:00 +00:00
parent a69b7d9d96
commit b86ab4ff15
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2009-11-12 Daniel Jacobowitz <dan@codesourcery.com>
* remote-fileio.c (remote_fileio_func_read): Limit console
reads to 16K.
2009-11-12 Daniel Jacobowitz <dan@codesourcery.com>
Paul Brook <paul@codesourcery.com>

15
gdb/remote-fileio.c
View File

@ -741,7 +741,7 @@ remote_fileio_func_read (char *buf)
static char *remaining_buf = NULL;
static int remaining_length = 0;
buffer = (gdb_byte *) xmalloc (32768);
buffer = (gdb_byte *) xmalloc (16384);
if (remaining_buf)
{
remote_fio_no_longjmp = 1;
@ -763,7 +763,18 @@ remote_fileio_func_read (char *buf)
}
else
{
ret = ui_file_read (gdb_stdtargin, (char *) buffer, 32767);
/* Windows (at least XP and Server 2003) has difficulty
with large reads from consoles. If a handle is
backed by a real console device, overly large reads
from the handle will fail and set errno == ENOMEM.
On a Windows Server 2003 system where I tested,
reading 26608 bytes from the console was OK, but
anything above 26609 bytes would fail. The limit has
been observed to vary on different systems. So, we
limit this read to something smaller than that - by a
safe margin, in case the limit depends on system
resources or version. */
ret = ui_file_read (gdb_stdtargin, (char *) buffer, 16383);
remote_fio_no_longjmp = 1;
if (ret > 0 && (size_t)ret > length)
{