OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Testsuite: Remove pie from trace tests 

Ubuntu/Debian defaults PIE to enabled.  This causes the trace tests
to fall over due to variables being returned as "unavailable".  The
tests were never designed to work with pie.

Simply ensure the nopie flag is always used for the failing tests.

This removes 100+ failures when running native-gdbserver on Ubuntu 18.04.

gdb/testsuite/ChangeLog:

	* gdb.trace/backtrace.exp: Use nopie flag.
	* gdb.trace/circ.exp: Likewise.
	* gdb.trace/collection.exp: Likewise.
	* gdb.trace/ftrace.exp: Likewise.
	* gdb.trace/mi-trace-unavailable.exp: Likewise.
	* gdb.trace/mi-traceframe-changed.exp: Likewise.
	* gdb.trace/qtro.exp: Likewise.
	* gdb.trace/read-memory.exp: Likewise.
	* gdb.trace/report.exp: Likewise.
	* gdb.trace/tfile.exp: Likewise.
	* gdb.trace/tfind.exp: Likewise.
	* gdb.trace/unavailable.exp: Likewise.
This commit is contained in:
Alan Hayward 2019-04-23 14:12:25 +01:00
parent 624a24513d
commit ba22ff8694
13 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,18 @@
2019-04-23 Alan Hayward <alan.hayward@arm.com>
* gdb.trace/backtrace.exp: Use nopie flag.
* gdb.trace/circ.exp: Likewise.
* gdb.trace/collection.exp: Likewise.
* gdb.trace/ftrace.exp: Likewise.
* gdb.trace/mi-trace-unavailable.exp: Likewise.
* gdb.trace/mi-traceframe-changed.exp: Likewise.
* gdb.trace/qtro.exp: Likewise.
* gdb.trace/read-memory.exp: Likewise.
* gdb.trace/report.exp: Likewise.
* gdb.trace/tfile.exp: Likewise.
* gdb.trace/tfind.exp: Likewise.
* gdb.trace/unavailable.exp: Likewise.
2019-04-22 Pedro Alves <palves@redhat.com>
* gdb.base/solib-probes-nosharedlibrary.c,

2
gdb/testsuite/gdb.trace/backtrace.exp
View File

@ -27,7 +27,7 @@ if ![gdb_trace_common_supports_arch] {
}
if [prepare_for_testing "failed to prepare" $executable $srcfile \
[list debug nowarnings]] {
[list debug nowarnings nopie]] {
return -1
}

2
gdb/testsuite/gdb.trace/circ.exp
View File

@ -17,7 +17,7 @@ load_lib "trace-support.exp"
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nowarnings}]} {
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nowarnings nopie}]} {
return -1
}

2
gdb/testsuite/gdb.trace/collection.exp
View File

@ -19,7 +19,7 @@ load_lib "trace-support.exp"
standard_testfile
set executable $testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nowarnings}]} {
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nowarnings nopie}]} {
return -1
}

2
gdb/testsuite/gdb.trace/ftrace.exp
View File

@ -53,7 +53,7 @@ set remote_libipa [gdb_load_shlib $libipa]
# file unused because linking not done" when building the object.
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
executable [list debug $additional_flags shlib=$libipa] ] != "" } {
executable [list debug nopie $additional_flags shlib=$libipa] ] != "" } {
untested "failed to compile"
return -1
}

2
gdb/testsuite/gdb.trace/mi-trace-unavailable.exp
View File

@ -17,7 +17,7 @@ load_lib trace-support.exp
standard_testfile trace-unavailable.c
if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug}] } {
if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug nopie}] } {
return -1
}

2
gdb/testsuite/gdb.trace/mi-traceframe-changed.exp
View File

@ -32,7 +32,7 @@ if {![is_remote host] && ![is_remote target]} {
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable \
[list debug nowarnings \
[list debug nowarnings nopie\
"additional_flags=-DTFILE_DIR=\"$tfile_dir\""]] \
!= "" } {
untested "failed to compile"

2
gdb/testsuite/gdb.trace/qtro.exp
View File

@ -22,7 +22,7 @@ load_lib trace-support.exp
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} {
return -1
}
clean_restart $testfile

2
gdb/testsuite/gdb.trace/read-memory.exp
View File

@ -17,7 +17,7 @@ load_lib "trace-support.exp"
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} {
return -1
}

2
gdb/testsuite/gdb.trace/report.exp
View File

@ -27,7 +27,7 @@ if ![gdb_trace_common_supports_arch] {
return -1
}
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
executable {debug nowarnings}] != "" } {
executable {debug nowarnings nopie}] != "" } {
untested "failed to compile"
return -1
}

2
gdb/testsuite/gdb.trace/tfile.exp
View File

@ -37,7 +37,7 @@ if {![is_remote host] && ![is_remote target]} {
standard_testfile
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
executable \
[list debug \
[list debug nopie\
"additional_flags=-DTFILE_DIR=\"$tfile_dir\""]] \
!= "" } {
untested "failed to compile"

2
gdb/testsuite/gdb.trace/tfind.exp
View File

@ -29,7 +29,7 @@ if ![gdb_trace_common_supports_arch] {
}
if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile" \
executable {debug nowarnings}] != "" } {
executable {debug nowarnings nopie}] != "" } {
untested "failed to compile"
return -1
}

2
gdb/testsuite/gdb.trace/unavailable.exp
View File

@ -19,7 +19,7 @@ standard_testfile unavailable.cc
set executable $testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
{debug nowarnings c++}]} {
{debug nowarnings c++ nopie}]} {
return -1
}