OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix cli_interp::cli_uiout resource leak found by Coverity

Browse Source 
This commit fixes a resource leak found by Coverity, where cli_interp's
constructor creates a new cli_ui_out, but there was no corresponding
destructor to free it.

gdb/ChangeLog:

	* cli/cli-interp.c (cli_interp::~cli_interp): New function.
This commit is contained in:
Gary Benson 2018-10-19 11:51:41 +01:00
parent b04480b119
commit ba543ca5af
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2018-10-19 Gary Benson <gbenson@redhat.com>
* cli/cli-interp.c (cli_interp::~cli_interp): New function.
2018-10-18 Sergio Durigan Junior <sergiodj@redhat.com>
PR cli/23785

6
gdb/cli/cli-interp.c
View File

@ -44,6 +44,7 @@ class cli_interp final : public cli_interp_base
{
public:
explicit cli_interp (const char *name);
~cli_interp ();
void init (bool top_level) override;
void resume () override;
@ -62,6 +63,11 @@ cli_interp::cli_interp (const char *name)
this->cli_uiout = cli_out_new (gdb_stdout);
}
cli_interp::~cli_interp ()
{
delete cli_uiout;
}
/* Suppress notification struct. */
struct cli_suppress_notification cli_suppress_notification =
{