OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Constify some remote-notif functions 

This constifies the "buf" arguments to various remote-notif functions
and updates the users.

gdb/ChangeLog
2019-01-14  Tom Tromey  <tom@tromey.com>

	* remote-notif.c (handle_notification, remote_notif_ack)
	(remote_notif_parse): Make "buf" const.
	* remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
	const.
	(remote_notif_parse, remote_notif_ack, handle_notification):
	Likewise.
	* remote.c (remote_notif_stop_parse): Make "buf" const.
	(remote_target::remote_parse_stop_reply): Make "buf" const.
	(remote_notif_stop_ack): Make "buf" const.
This commit is contained in:
Tom Tromey 2019-01-06 13:30:00 -07:00
parent 05be00a884
commit bb27775165
4 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/ChangeLog
View File

@ -1,3 +1,15 @@
2019-01-14 Tom Tromey <tom@tromey.com>
* remote-notif.c (handle_notification, remote_notif_ack)
(remote_notif_parse): Make "buf" const.
* remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
const.
(remote_notif_parse, remote_notif_ack, handle_notification):
Likewise.
* remote.c (remote_notif_stop_parse): Make "buf" const.
(remote_target::remote_parse_stop_reply): Make "buf" const.
(remote_notif_stop_ack): Make "buf" const.
2019-01-14 Tom Tromey <tom@tromey.com>
* remote.c (remote_console_output): Make parameter const.

6
gdb/remote-notif.c
View File

@ -59,7 +59,7 @@ static void do_notif_event_xfree (void *arg);
void
remote_notif_ack (remote_target *remote,
struct notif_client *nc, char *buf)
struct notif_client *nc, const char *buf)
{
struct notif_event *event = nc->alloc_event ();
struct cleanup *old_chain
@ -79,7 +79,7 @@ remote_notif_ack (remote_target *remote,
struct notif_event *
remote_notif_parse (remote_target *remote,
struct notif_client *nc, char *buf)
struct notif_client *nc, const char *buf)
{
struct notif_event *event = nc->alloc_event ();
struct cleanup *old_chain
@ -126,7 +126,7 @@ remote_async_get_pending_events_handler (gdb_client_data data)
update STATE. */
void
handle_notification (struct remote_notif_state *state, char *buf)
handle_notification (struct remote_notif_state *state, const char *buf)
{
struct notif_client *nc;
size_t i;

11
gdb/remote-notif.h
View File

@ -55,13 +55,13 @@ typedef struct notif_client
function may throw exception if contents in BUF is not the
expected event. */
void (*parse) (remote_target *remote,
struct notif_client *self, char *buf,
struct notif_client *self, const char *buf,
struct notif_event *event);
/* Send field <ack_command> to remote, and do some checking. If
something wrong, throw an exception. */
void (*ack) (remote_target *remote,
struct notif_client *self, char *buf,
struct notif_client *self, const char *buf,
struct notif_event *event);
/* Check this notification client can get pending events in
@ -106,15 +106,16 @@ struct remote_notif_state
struct notif_event *pending_event[REMOTE_NOTIF_LAST];
};
void remote_notif_ack (remote_target *remote, notif_client *nc, char *buf);
void remote_notif_ack (remote_target *remote, notif_client *nc,
const char *buf);
struct notif_event *remote_notif_parse (remote_target *remote,
notif_client *nc,
char *buf);
const char *buf);
void notif_event_xfree (struct notif_event *event);
void handle_notification (struct remote_notif_state *notif_state,
char *buf);
const char *buf);
void remote_notif_process (struct remote_notif_state *state,
struct notif_client *except);

8
gdb/remote.c
View File

@ -768,7 +768,7 @@ public: /* Remote specific methods. */
struct stop_reply *remote_notif_remove_queued_reply (ptid_t ptid);
struct stop_reply *queued_stop_reply (ptid_t ptid);
int peek_stop_reply (ptid_t ptid);
void remote_parse_stop_reply (char *buf, stop_reply *event);
void remote_parse_stop_reply (const char *buf, stop_reply *event);
void remote_stop_ns (ptid_t ptid);
void remote_interrupt_as ();
@ -6864,7 +6864,7 @@ remote_target::stop_reply_queue_length ()
void
remote_notif_stop_parse (remote_target *remote,
struct notif_client *self, char *buf,
struct notif_client *self, const char *buf,
struct notif_event *event)
{
remote->remote_parse_stop_reply (buf, (struct stop_reply *) event);
@ -6872,7 +6872,7 @@ remote_notif_stop_parse (remote_target *remote,
static void
remote_notif_stop_ack (remote_target *remote,
struct notif_client *self, char *buf,
struct notif_client *self, const char *buf,
struct notif_event *event)
{
struct stop_reply *stop_reply = (struct stop_reply *) event;
@ -7201,7 +7201,7 @@ strprefix (const char *p, const char *pend, const char *prefix)
result is stored in EVENT, or throws an error. */
void
remote_target::remote_parse_stop_reply (char *buf, stop_reply *event)
remote_target::remote_parse_stop_reply (const char *buf, stop_reply *event)
{
remote_arch_state *rsa = NULL;
ULONGEST addr;