OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* regcache.c (registers_length): Remove.

Browse Source 
(set_register_cache): Verify that PBUFSIZ is large enough to hold a
	full register packet.
	* regcache.h (registers_length): Remove prototype.
	* server.h (PBUFSIZ): Define to 16384.
This commit is contained in:
Ulrich Weigand 2008-05-08 19:46:56 +00:00
parent 75517b77b5
commit bb9c3d36f1
4 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,11 @@
2008-05-08 Ulrich Weigand <uweigand@de.ibm.com>
* regcache.c (registers_length): Remove.
(set_register_cache): Verify that PBUFSIZ is large enough to hold a
full register packet.
* regcache.h (registers_length): Remove prototype.
* server.h (PBUFSIZ): Define to 16384.
2008-05-03 Ulrich Weigand <uweigand@de.ibm.com>
* configure.srv (powerpc*-*-linux*): Set srv_regobj to

10
gdb/gdbserver/regcache.c
View File

@ -86,12 +86,6 @@ regcache_invalidate ()
for_each_inferior (&all_threads, regcache_invalidate_one);
}
int
registers_length (void)
{
return 2 * register_bytes;
}
void *
new_register_cache (void)
{
@ -147,6 +141,10 @@ set_register_cache (struct reg *regs, int n)
register_bytes = offset / 8;
/* Make sure PBUFSIZ is large enough to hold a full register packet. */
if (2 * register_bytes + 32 > PBUFSIZ)
fatal ("Register packet size exceeds PBUFSIZ.");
/* Re-allocate all pre-existing register caches. */
for_each_inferior (&all_threads, realloc_register_cache);
}

4
gdb/gdbserver/regcache.h
View File

@ -43,10 +43,6 @@ void registers_to_string (char *buf);
void registers_from_string (char *buf);
/* Return the size in bytes of a string-encoded register packet. */
int registers_length (void);
/* Return a pointer to the description of register ``n''. */
struct reg *find_register_by_number (int n);

9
gdb/gdbserver/server.h
View File

@ -225,11 +225,10 @@ void warning (const char *string,...) ATTR_FORMAT (printf, 1, 2);
is chosen to fill up a packet (the headers account for the 32). */
#define MAXBUFBYTES(N) (((N)-32)/2)
/* Buffer sizes for transferring memory, registers, etc. Round up PBUFSIZ to
hold all the registers, at least. */
#define PBUFSIZ ((registers_length () + 32 > 2000) \
? (registers_length () + 32) \
: 2000)
/* Buffer sizes for transferring memory, registers, etc. Set to a constant
value to accomodate multiple register formats. This value must be at least
as large as the largest register set supported by gdbserver. */
#define PBUFSIZ 16384
/* Version information, from version.c. */
extern const char version[];