OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix cast of xml_find_attribute's return value

Browse Source 
The cast auto-insert script inserted long unsigned int, but we should
use the typedef ULONGEST.  Fixes build failures on i386.

gdb/ChangeLog:

	* btrace.c (parse_xml_btrace_block): Fix cast of
	xml_find_attribute's return value.
	* memory-map.c (memory_map_start_memory): Likewise.
	* solib-svr4.c (library_list_start_library): Likewise.
	* solib-target.c (library_list_start_segment): Likewise.
	(library_list_start_section): Likewise.
	* tracepoint.c (traceframe_info_start_memory): Likewise.
This commit is contained in:
Simon Marchi 2015-09-26 17:15:05 -04:00
parent ba587d55a5
commit bc84451b7a
6 changed files with 22 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/ChangeLog
View File

@ -1,3 +1,13 @@
2015-09-26 Simon Marchi <simark@nova.polymtl.ca>
* btrace.c (parse_xml_btrace_block): Fix cast of
xml_find_attribute's return value.
* memory-map.c (memory_map_start_memory): Likewise.
* solib-svr4.c (library_list_start_library): Likewise.
* solib-target.c (library_list_start_segment): Likewise.
(library_list_start_section): Likewise.
* tracepoint.c (traceframe_info_start_memory): Likewise.
2015-09-26 Iain Buclaw <ibuclaw@gdcproject.org>
* d-namespace.c (d_lookup_symbol): New arg langdef.

4
gdb/btrace.c
View File

@ -1418,8 +1418,8 @@ parse_xml_btrace_block (struct gdb_xml_parser *parser,
gdb_xml_error (parser, _("Btrace format error."));
}
begin = (long unsigned int *) xml_find_attribute (attributes, "begin")->value;
end = (long unsigned int *) xml_find_attribute (attributes, "end")->value;
begin = (ULONGEST *) xml_find_attribute (attributes, "begin")->value;
end = (ULONGEST *) xml_find_attribute (attributes, "end")->value;
block = VEC_safe_push (btrace_block_s, btrace->variant.bts.blocks, NULL);
block->begin = *begin;

6
gdb/memory-map.c
View File

@ -61,11 +61,11 @@ memory_map_start_memory (struct gdb_xml_parser *parser,
ULONGEST *start_p, *length_p, *type_p;
start_p
= (long unsigned int *) xml_find_attribute (attributes, "start")->value;
= (ULONGEST *) xml_find_attribute (attributes, "start")->value;
length_p
= (long unsigned int *) xml_find_attribute (attributes, "length")->value;
= (ULONGEST *) xml_find_attribute (attributes, "length")->value;
type_p
= (long unsigned int *) xml_find_attribute (attributes, "type")->value;
= (ULONGEST *) xml_find_attribute (attributes, "type")->value;
mem_region_init (r);
r->lo = *start_p;

6
gdb/solib-svr4.c
View File

@ -1166,11 +1166,11 @@ library_list_start_library (struct gdb_xml_parser *parser,
const char *name
= (const char *) xml_find_attribute (attributes, "name")->value;
ULONGEST *lmp
= (long unsigned int *) xml_find_attribute (attributes, "lm")->value;
= (ULONGEST *) xml_find_attribute (attributes, "lm")->value;
ULONGEST *l_addrp
= (long unsigned int *) xml_find_attribute (attributes, "l_addr")->value;
= (ULONGEST *) xml_find_attribute (attributes, "l_addr")->value;
ULONGEST *l_ldp
= (long unsigned int *) xml_find_attribute (attributes, "l_ld")->value;
= (ULONGEST *) xml_find_attribute (attributes, "l_ld")->value;
struct so_list *new_elem;
new_elem = XCNEW (struct so_list);

4
gdb/solib-target.c
View File

@ -83,7 +83,7 @@ library_list_start_segment (struct gdb_xml_parser *parser,
VEC(lm_info_p) **list = (VEC(lm_info_p) **) user_data;
struct lm_info *last = VEC_last (lm_info_p, *list);
ULONGEST *address_p
= (long unsigned int *) xml_find_attribute (attributes, "address")->value;
= (ULONGEST *) xml_find_attribute (attributes, "address")->value;
CORE_ADDR address = (CORE_ADDR) *address_p;
if (last->section_bases != NULL)
@ -101,7 +101,7 @@ library_list_start_section (struct gdb_xml_parser *parser,
VEC(lm_info_p) **list = (VEC(lm_info_p) **) user_data;
struct lm_info *last = VEC_last (lm_info_p, *list);
ULONGEST *address_p
= (long unsigned int *) xml_find_attribute (attributes, "address")->value;
= (ULONGEST *) xml_find_attribute (attributes, "address")->value;
CORE_ADDR address = (CORE_ADDR) *address_p;
if (last->segment_bases != NULL)

4
gdb/tracepoint.c
View File

@ -4194,9 +4194,9 @@ traceframe_info_start_memory (struct gdb_xml_parser *parser,
ULONGEST *start_p, *length_p;
start_p
= (long unsigned int *) xml_find_attribute (attributes, "start")->value;
= (ULONGEST *) xml_find_attribute (attributes, "start")->value;
length_p
= (long unsigned int *) xml_find_attribute (attributes, "length")->value;
= (ULONGEST *) xml_find_attribute (attributes, "length")->value;
r->start = *start_p;
r->length = *length_p;