Enable conditional breakpoints for targets that support software single step in GDBServer
This patch enables support for conditional breakpoints if the target supports software single step. This was disabled before as the implementations of software single step were too simple as discussed in https://sourceware.org/ml/gdb-patches/2015-04/msg01110.html. Since these issues are now fixed support can be added back. New tests passing : PASS: gdb.base/cond-eval-mode.exp: set breakpoint condition-evaluation target and related... No regressions, tested on ubuntu 14.04 ARMv7 and x86. With gdbserver-{native,extended} / { -marm -mthumb } gdb/gdbserver/ChangeLog: * server.c (handle_query): Call target_supports_software_single_step.
This commit is contained in:
parent
7fe5e27e9d
commit
bd2b290956
|
@ -1,3 +1,7 @@
|
|||
2015-12-18 Antoine Tremblay <antoine.tremblay@ericsson.com>
|
||||
|
||||
* server.c (handle_query): Call target_supports_software_single_step.
|
||||
|
||||
2015-12-18 Antoine Tremblay <antoine.tremblay@ericsson.com>
|
||||
|
||||
* linux-low.c (single_step): New function.
|
||||
|
|
|
@ -2290,13 +2290,9 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
|
|||
strcat (own_buf, ";tracenz+");
|
||||
}
|
||||
|
||||
if (target_supports_hardware_single_step ())
|
||||
if (target_supports_hardware_single_step ()
|
||||
|| target_supports_software_single_step () )
|
||||
{
|
||||
/* Support target-side breakpoint conditions and commands.
|
||||
GDBserver needs to step over the breakpoint if the condition
|
||||
is false. GDBserver software single step is too simple, so
|
||||
disable conditional breakpoints if the target doesn't have
|
||||
hardware single step. */
|
||||
strcat (own_buf, ";ConditionalBreakpoints+");
|
||||
}
|
||||
strcat (own_buf, ";BreakpointCommands+");
|
||||
|
|
Loading…
Reference in New Issue