OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: Remove casts of NULL during assignment. 

In the following code:

    struct symbol *wsym = (struct symbol *) NULL;

the cast of NULL is redundant, it adds noise, and is just one more thing
to change if the type of wsym ever changes.  There are a relatively
small number of places in gdb where the above code pattern is used.
Usually the cast is removed like this:

    struct symbol *wsym = NULL;

This commit updates all the places within the gdb/ directory where we
cast NULL during assignment, removing the cast.

gdb/ChangeLog:

	* c-valprint.c (print_unpacked_pointer): Remove cast of NULL
	pointer.
	* dbxread.c (dbx_end_psymtab): Likewise.
	* gnu-nat.c (gnu_write_inferior): Likewise.
	* mdebugread.c (cross_ref): Likewise.
	* p-valprint.c (pascal_val_print): Likewise.
	* xcoffread.c (xcoff_end_psymtab): Likewise.
This commit is contained in:
Andrew Burgess 2015-08-31 21:19:49 +01:00
parent 02f024f9a5
commit be90335825
7 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/ChangeLog
View File

@ -1,3 +1,13 @@
2015-09-04 Andrew Burgess <andrew.burgess@embecosm.com>
* c-valprint.c (print_unpacked_pointer): Remove cast of NULL
pointer.
* dbxread.c (dbx_end_psymtab): Likewise.
* gnu-nat.c (gnu_write_inferior): Likewise.
* mdebugread.c (cross_ref): Likewise.
* p-valprint.c (pascal_val_print): Likewise.
* xcoffread.c (xcoff_end_psymtab): Likewise.
2015-09-04 Yao Qi <yao.qi@linaro.org>
* NEWS: Mention the aarch64 multi-arch debugging support.

4
gdb/c-valprint.c
View File

@ -193,9 +193,9 @@ print_unpacked_pointer (struct type *type, struct type *elttype,
if (vt_address && options->vtblprint)
{
struct value *vt_val;
struct symbol *wsym = (struct symbol *) NULL;
struct symbol *wsym = NULL;
struct type *wtype;
struct block *block = (struct block *) NULL;
struct block *block = NULL;
struct field_of_this_result is_this_fld;
if (want_space)

2
gdb/dbxread.c
View File

@ -2341,7 +2341,7 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
discard_psymtab (objfile, pst);
/* Indicate that psymtab was thrown away. */
pst = (struct partial_symtab *) NULL;
pst = NULL;
}
return pst;
}

2
gdb/gnu-nat.c
View File

@ -2350,7 +2350,7 @@ gnu_write_inferior (task_t task, CORE_ADDR addr,
char *errstr = "Bug in gnu_write_inferior";
struct vm_region_list *region_element;
struct vm_region_list *region_head = (struct vm_region_list *) NULL;
struct vm_region_list *region_head = NULL;
/* Get memory from inferior with page aligned addresses. */
err = vm_read (task,

2
gdb/mdebugread.c
View File

@ -4376,7 +4376,7 @@ cross_ref (int fd, union aux_ext *ax, struct type **tpp,
int xref_fd;
struct mdebug_pending *pend;
*tpp = (struct type *) NULL;
*tpp = NULL;
(*debug_swap->swap_rndx_in) (bigend, &ax->a_rndx, rn);

4
gdb/p-valprint.c
View File

@ -239,9 +239,9 @@ pascal_val_print (struct type *type, const gdb_byte *valaddr,
if (vt_address && options->vtblprint)
{
struct value *vt_val;
struct symbol *wsym = (struct symbol *) NULL;
struct symbol *wsym = NULL;
struct type *wtype;
struct block *block = (struct block *) NULL;
struct block *block = NULL;
struct field_of_this_result is_this_fld;
if (want_space)

2
gdb/xcoffread.c
View File

@ -2108,7 +2108,7 @@ xcoff_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
discard_psymtab (objfile, pst);
/* Indicate that psymtab was thrown away. */
pst = (struct partial_symtab *) NULL;
pst = NULL;
}
return pst;
}