OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ARC: Use of uninitialised value 

* arc-dis.c (find_format): Use ISO C string concatenation rather
	than line continuation within a string.  Don't access needs_limm
	before testing opcode != NULL.
This commit is contained in:
Alan Modra 2020-03-22 20:02:55 +10:30
parent 03704c7704
commit beea5cc1bc
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opcodes/ChangeLog
View File

@ -1,3 +1,9 @@
2020-03-22 Alan Modra <amodra@gmail.com>
* arc-dis.c (find_format): Use ISO C string concatenation rather
than line continuation within a string. Don't access needs_limm
before testing opcode != NULL.
2020-03-22 Alan Modra <amodra@gmail.com>
* ns32k-dis.c (print_insn_arg): Update comment.

7
opcodes/arc-dis.c
View File

@ -436,8 +436,9 @@ find_format (bfd_vma memaddr,
opcode = arcExtMap_genOpcode (i, isa_mask, &errmsg);
if (opcode == NULL)
{
(*info->fprintf_func) (info->stream, "\
An error occured while generating the extension instruction operations");
(*info->fprintf_func) (info->stream,
_("An error occured while generating the "
"extension instruction operations"));
*opcode_result = NULL;
return FALSE;
}
@ -452,7 +453,7 @@ An error occured while generating the extension instruction operations");
opcode = find_format_from_table (info, arc_opcodes, insn, *insn_len,
isa_mask, &needs_limm, TRUE);
if (needs_limm && opcode != NULL)
if (opcode != NULL && needs_limm)
{
bfd_byte buffer[4];
int status;