From bf1aae13f09da87af876df4c6b1fa6d8f69cc12e Mon Sep 17 00:00:00 2001 From: Michael Snyder Date: Thu, 11 Dec 1997 22:34:09 +0000 Subject: [PATCH] Thu Dec 11 14:28:01 1997 Michael Snyder (msnyder@cleaver.cygnus.com) * tracepoint.c (trace_find_command): don't error if going backwards thru the trace buffer in a loop. * (struct tracepoint): delete unused field. --- gdb/ChangeLog | 6 ++++++ gdb/tracepoint.c | 8 ++------ gdb/tracepoint.h | 4 ---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 78770793eb..27e186651f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +Thu Dec 11 14:28:01 1997 Michael Snyder (msnyder@cleaver.cygnus.com) + + * tracepoint.c (trace_find_command): don't error if going + backwards thru the trace buffer in a loop. + * (struct tracepoint): delete unused field. + Wed Dec 10 13:16:45 1997 Keith Seitz * gdbtk.c (gdb_get_tracepoint_info): Use info in struct diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 2b81911194..eda6d278ce 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -360,7 +360,7 @@ trace_command (arg, from_tty) struct symtabs_and_lines sals; struct symtab_and_line sal; struct tracepoint *t; - char *addr_start = 0, *addr_end = 0, *cond_start = 0, *cond_end = 0; + char *addr_start = 0, *addr_end = 0; int i; if (!arg || !*arg) @@ -399,8 +399,6 @@ trace_command (arg, from_tty) t->addr_string = canonical[i]; else if (addr_start) t->addr_string = savestring (addr_start, addr_end - addr_start); - if (cond_start) - t->cond_string = savestring (cond_start, cond_end - cond_start); /* Let the UI know of any additions */ if (create_tracepoint_hook) @@ -550,8 +548,6 @@ tracepoint_operation (t, from_tty, opcode) if (delete_tracepoint_hook) delete_tracepoint_hook (t); - if (t->cond_string) - free (t->cond_string); if (t->addr_string) free (t->addr_string); if (t->source_file) @@ -1757,7 +1753,7 @@ trace_find_command (args, from_tty) { if (traceframe_number == -1) error ("not debugging trace buffer"); - else if (traceframe_number == 0) + else if (from_tty && traceframe_number == 0) error ("already at start of trace buffer"); frameno = traceframe_number - 1; diff --git a/gdb/tracepoint.h b/gdb/tracepoint.h index d58a7dbfa8..0ff59821a4 100644 --- a/gdb/tracepoint.h +++ b/gdb/tracepoint.h @@ -80,10 +80,6 @@ struct tracepoint /* Input radix we used to set the tracepoint. */ int input_radix; - /* String form of the tracepoint trigger condition (malloc'd), - or NULL if there is no condition. */ - char *cond_string; - /* Count of the number of times this tracepoint was taken, dumped with the info, but not used for anything else. Useful for seeing how many times you hit a tracepoint prior to the program