OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove some uses of "object_files"

Browse Source 
The "object_files" macro is sometimes used when iterating over
objfiles.  This patch removes a few such uses in favor of the new
range adapter.

gdb/ChangeLog
2019-04-10  Tom Tromey  <tom@tromey.com>

	* ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
	* minsyms.c (lookup_minimal_symbol): Use foreach.
	(lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
	(lookup_minimal_symbol_solib_trampoline): Likewise.
	* symfile.c (reread_symbols): Use foreach.
This commit is contained in:
Tom Tromey 2019-01-19 21:30:36 -07:00
parent b05971a652
commit bf227d6105
4 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2019-04-10 Tom Tromey <tom@tromey.com>
* ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
* minsyms.c (lookup_minimal_symbol): Use foreach.
(lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
(lookup_minimal_symbol_solib_trampoline): Likewise.
* symfile.c (reread_symbols): Use foreach.
2019-04-09 Ivan Begert <ivanbegert@gmail.com>
Tom Tromey <tromey@adacore.com>

3
gdb/ia64-tdep.c
View File

@ -2845,7 +2845,6 @@ ia64_get_dyn_info_list (unw_addr_space_t as,
unw_word_t *dilap, void *arg)
{
struct obj_section *text_sec;
struct objfile *objfile;
unw_word_t ip, addr;
unw_dyn_info_t di;
int ret;
@ -2853,7 +2852,7 @@ ia64_get_dyn_info_list (unw_addr_space_t as,
if (!libunwind_is_initialized ())
return -UNW_ENOINFO;
for (objfile = object_files; objfile; objfile = objfile->next)
for (objfile *objfile : current_program_space->objfiles ())
{
void *buf = NULL;

26
gdb/minsyms.c
View File

@ -308,7 +308,6 @@ struct bound_minimal_symbol
lookup_minimal_symbol (const char *name, const char *sfile,
struct objfile *objf)
{
struct objfile *objfile;
found_minimal_symbols found;
unsigned int mangled_hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE;
@ -323,10 +322,11 @@ lookup_minimal_symbol (const char *name, const char *sfile,
lookup_name_info lookup_name (name, symbol_name_match_type::FULL);
for (objfile = object_files;
objfile != NULL && found.external_symbol.minsym == NULL;
objfile = objfile->next)
for (objfile *objfile : current_program_space->objfiles ())
{
if (found.external_symbol.minsym != NULL)
break;
if (objf == NULL || objf == objfile
|| objf == objfile->separate_debug_objfile_backlink)
{
@ -522,17 +522,17 @@ iterate_over_minimal_symbols
struct bound_minimal_symbol
lookup_minimal_symbol_text (const char *name, struct objfile *objf)
{
struct objfile *objfile;
struct minimal_symbol *msymbol;
struct bound_minimal_symbol found_symbol = { NULL, NULL };
struct bound_minimal_symbol found_file_symbol = { NULL, NULL };
unsigned int hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE;
for (objfile = object_files;
objfile != NULL && found_symbol.minsym == NULL;
objfile = objfile->next)
for (objfile *objfile : current_program_space->objfiles ())
{
if (found_symbol.minsym != NULL)
break;
if (objf == NULL || objf == objfile
|| objf == objfile->separate_debug_objfile_backlink)
{
@ -574,14 +574,11 @@ struct minimal_symbol *
lookup_minimal_symbol_by_pc_name (CORE_ADDR pc, const char *name,
struct objfile *objf)
{
struct objfile *objfile;
struct minimal_symbol *msymbol;
unsigned int hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE;
for (objfile = object_files;
objfile != NULL;
objfile = objfile->next)
for (objfile *objfile : current_program_space->objfiles ())
{
if (objf == NULL || objf == objfile
|| objf == objfile->separate_debug_objfile_backlink)
@ -606,15 +603,12 @@ struct bound_minimal_symbol
lookup_minimal_symbol_solib_trampoline (const char *name,
struct objfile *objf)
{
struct objfile *objfile;
struct minimal_symbol *msymbol;
struct bound_minimal_symbol found_symbol = { NULL, NULL };
unsigned int hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE;
for (objfile = object_files;
objfile != NULL;
objfile = objfile->next)
for (objfile *objfile : current_program_space->objfiles ())
{
if (objf == NULL || objf == objfile
|| objf == objfile->separate_debug_objfile_backlink)

3
gdb/symfile.c
View File

@ -2427,7 +2427,6 @@ remove_symbol_file_command (const char *args, int from_tty)
void
reread_symbols (void)
{
struct objfile *objfile;
long new_modtime;
struct stat new_statbuf;
int res;
@ -2439,7 +2438,7 @@ reread_symbols (void)
This routine should then walk down each partial symbol table
and see if the symbol table that it originates from has been changed. */
for (objfile = object_files; objfile; objfile = objfile->next)
for (objfile *objfile : current_program_space->objfiles ())
{
if (objfile->obfd == NULL)
continue;