OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

More procfs.c simplification 

There are only two architectures using procfs.c (i386/SPARC), and none
of their corresponding nat files overrides any target method.  Move
the add_target calls to procfs.c directly.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
	procfs_target/add_target here.
	* procfs.c (procfs_target): Make static.
	(_initialize_procfs): Call add_target here.
	* procfs.h (struct target_ops): Remove forward declaration.
	(procfs_target): Remove declaration.
	* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
This commit is contained in:
Pedro Alves 2018-05-03 00:37:07 +01:00
parent b5c8fcb1b4
commit c1955e1792
5 changed files with 15 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/ChangeLog
View File

@ -1,3 +1,13 @@
2018-05-02 Pedro Alves <palves@redhat.com>
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
procfs_target/add_target here.
* procfs.c (procfs_target): Make static.
(_initialize_procfs): Call add_target here.
* procfs.h (struct target_ops): Remove forward declaration.
(procfs_target): Remove declaration.
* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2018-05-02 Pedro Alves <palves@redhat.com>
* procfs.c (procfs_stopped_by_watchpoint)

7
gdb/i386-sol2-nat.c
View File

@ -133,11 +133,6 @@ fill_fpregset (const struct regcache *regcache,
void
_initialize_amd64_sol2_nat (void)
{
struct target_ops *t;
/* Fill in the generic procfs methods. */
t = procfs_target ();
#if defined (PR_MODEL_NATIVE) && (PR_MODEL_NATIVE == PR_MODEL_LP64)
amd64_native_gregset32_reg_offset = amd64_sol2_gregset32_reg_offset;
amd64_native_gregset32_num_regs =
@ -146,6 +141,4 @@ _initialize_amd64_sol2_nat (void)
amd64_native_gregset64_num_regs =
ARRAY_SIZE (amd64_sol2_gregset64_reg_offset);
#endif
add_target (t);
}

6
gdb/procfs.c
View File

@ -171,7 +171,9 @@ procfs_auxv_parse (struct target_ops *ops, gdb_byte **readptr,
}
#endif
struct target_ops *
/* Create a procfs target. */
static struct target_ops *
procfs_target (void)
{
struct target_ops *t = inf_child_target ();
@ -3770,6 +3772,8 @@ _initialize_procfs (void)
_("Cancel a trace of entries into the syscall."));
add_com ("proc-untrace-exit", no_class, proc_untrace_sysexit_cmd,
_("Cancel a trace of exits from the syscall."));
add_target (procfs_target ());
}
/* =================== END, GDB "MODULE" =================== */

7
gdb/procfs.h
View File

@ -17,13 +17,6 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
struct target_ops;
/* Create a prototype generic procfs target. The client can override
it with local methods. */
extern struct target_ops *procfs_target (void);
/* Return a ptid for which we guarantee we will be able to find a
'live' procinfo. */

9
gdb/sparc-sol2-nat.c
View File

@ -97,12 +97,3 @@ fill_fpregset (const struct regcache *regcache,
{
sparc_collect_fpregset (&sparc_sol2_fpregmap, regcache, regnum, fpregs);
}
void
_initialize_sparc_sol2_nat (void)
{
struct target_ops *t;
t = procfs_target ();
add_target (t);
}