OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add asserts in target_fetch/store_registers 

We are currently assuming that regcache->ptid is equal to inferior_ptid
when we call target_fetch/store_registers.  These asserts just validate
that assumption.  Also, since the following patches will change target
code to use regcache->ptid instead of inferior_ptid, asserting that they
are the same should ensure that our changes don't have any unintended
consequences.

gdb/ChangeLog:

	* target.c (target_fetch_registers, target_store_registers): Add
	assert.
This commit is contained in:
Simon Marchi 2017-03-13 18:51:38 -04:00 committed by Simon Marchi
parent ddaaf0fb86
commit c6386875ba
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-03-13 Simon Marchi <simon.marchi@polymtl.ca>
* target.c (target_fetch_registers, target_store_registers): Add
assert.
2017-03-13 Simon Marchi <simon.marchi@polymtl.ca>
* regcache.h (regcache_get_ptid): New function.

4
gdb/target.c
View File

@ -3587,6 +3587,8 @@ debug_print_register (const char * func,
void
target_fetch_registers (struct regcache *regcache, int regno)
{
gdb_assert (ptid_equal (regcache_get_ptid (regcache), inferior_ptid));
current_target.to_fetch_registers (&current_target, regcache, regno);
if (targetdebug)
debug_print_register ("target_fetch_registers", regcache, regno);
@ -3598,6 +3600,8 @@ target_store_registers (struct regcache *regcache, int regno)
if (!may_write_registers)
error (_("Writing to registers is not allowed (regno %d)"), regno);
gdb_assert (ptid_equal (regcache_get_ptid (regcache), inferior_ptid));
current_target.to_store_registers (&current_target, regcache, regno);
if (targetdebug)
{