OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add two missing return values in gdb.python/py-nested-maps.c 

Two functions in gdb.python/py-nested-maps.c are missing return
values.  This causes clang to fail to compile the file with the
following error:
  warning: control reaches end of non-void function [-Wreturn-type]

This commit fixes, by causing the two functions to return pointers
to the objects they've just allocated and initialized.  I didn't
investigate how this test had been passing with other compilers;
I'm assuming serendipity, that in each function the value to be
returned was already in the register it would need to be in to be
the function's return value.

gdb/testsuite/ChangeLog:

	* gdb.python/py-nested-maps.c (create_map): Add missing return
	value.
	(create_map_map): Likewise.
This commit is contained in:
Gary Benson 2020-06-16 12:41:28 +01:00
parent 90cd2aad03
commit c802e8a76c
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2020-06-16 Gary Benson <gbenson@redhat.com>
* gdb.python/py-nested-maps.c (create_map): Add missing return
value.
(create_map_map): Likewise.
2020-06-15 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.base/jit-elf-so.exp: Refer to the global main_loader_basename

2
gdb/testsuite/gdb.python/py-nested-maps.c
View File

@ -62,6 +62,7 @@ create_map (const char *name)
m->keys = NULL;
m->values = NULL;
m->show_header = 0;
return m;
}
void
@ -85,6 +86,7 @@ create_map_map (void)
mm->length = 0;
mm->values = NULL;
mm->show_header = 0;
return mm;
}
void