OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: Use UNSUPPORTED not XFAIL for unsupported target features

Browse Source 
If a target does not support making function calls from GDB then in a
number of test files, we currently report an XFAIL and skip some, or all
of the tests.  This commit changes the XFAIL to an UNSUPPORTED as this
seems more appropriate in these cases.

Some of the tests used bug ID 2416 to be reported in the XFAIL.  In the
current GDB bugzilla bug 2416 has nothing to do with calling target
functions from GDB.

gdb/testsuite/ChangeLog:

	* gdb.base/call-ar-st.exp: Report unsupported rather than xfail
	for unsupported target features.
	* gdb.base/call-rt-st.exp: Likewise.
	* gdb.base/call-sc.exp: Likewise.
	* gdb.base/call-signal-resume.exp: Likewise.
	* gdb.base/call-strs.exp: Likewise.
	* gdb.base/callexit.exp: Likewise.
	* gdb.base/callfuncs.exp: Likewise.
	* gdb.base/nodebug.exp: Likewise.
	* gdb.base/printcmds.exp: Likewise.
	* gdb.base/ptype.exp: Likewise.
	* gdb.base/structs.exp: Likewise.
	* gdb.base/unwindonsignal.exp: Likewise.
	* gdb.cp/gdb2495.exp: Likewise.
	* gdb.cp/templates.exp: Likewise.
	* gdb.cp/virtfunc.exp: Likewise.
	* gdb.threads/hand-call-in-threads.exp: Likewise.
	* gdb.threads/interrupted-hand-call.exp: Likewise.
	* gdb.threads/thread-unwindonsignal.exp: Likewise.
This commit is contained in:
Andrew Burgess 2016-06-08 10:12:56 +01:00
parent 82f46e2cc1
commit cad8e26d2a
19 changed files with 41 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,25 @@
2016-06-13 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.base/call-ar-st.exp: Report unsupported rather than xfail
for unsupported target features.
* gdb.base/call-rt-st.exp: Likewise.
* gdb.base/call-sc.exp: Likewise.
* gdb.base/call-signal-resume.exp: Likewise.
* gdb.base/call-strs.exp: Likewise.
* gdb.base/callexit.exp: Likewise.
* gdb.base/callfuncs.exp: Likewise.
* gdb.base/nodebug.exp: Likewise.
* gdb.base/printcmds.exp: Likewise.
* gdb.base/ptype.exp: Likewise.
* gdb.base/structs.exp: Likewise.
* gdb.base/unwindonsignal.exp: Likewise.
* gdb.cp/gdb2495.exp: Likewise.
* gdb.cp/templates.exp: Likewise.
* gdb.cp/virtfunc.exp: Likewise.
* gdb.threads/hand-call-in-threads.exp: Likewise.
* gdb.threads/interrupted-hand-call.exp: Likewise.
* gdb.threads/thread-unwindonsignal.exp: Likewise.
2016-06-10 Tom Tromey <tom@tromey.com>
PR rust/20110:

3
gdb/testsuite/gdb.base/call-ar-st.exp
View File

@ -22,8 +22,7 @@ standard_testfile
# Some targets can't call functions, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/call-rt-st.exp
View File

@ -40,8 +40,7 @@ if [get_compiler_info] {
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/call-sc.exp
View File

@ -23,8 +23,7 @@
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*"
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/call-signal-resume.exp
View File

@ -36,8 +36,7 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/call-strs.exp
View File

@ -28,8 +28,7 @@ standard_testfile
# Some targets can't call functions, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/callexit.exp
View File

@ -24,8 +24,7 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/callfuncs.exp
View File

@ -26,8 +26,7 @@ if [support_complex_tests] {
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/nodebug.exp
View File

@ -123,8 +123,7 @@ if [runto inner] then {
# This test is not as obscure as it might look. `p getenv ("TERM")'
# is a real-world example, at least on many systems.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "p/c array_index(\"abcdef\",2)"
unsupported "p/c array_index(\"abcdef\",2)"
} else {
# We need to up this because this can be really slow on some boards.
# (malloc() is called as part of the test).

6
gdb/testsuite/gdb.base/printcmds.exp
View File

@ -683,8 +683,7 @@ proc test_print_string_constants {} {
gdb_test_no_output "set print elements 50"
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
return
}
@ -707,8 +706,7 @@ proc test_print_string_constants {} {
proc test_print_array_constants {} {
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
return
}

6
gdb/testsuite/gdb.base/ptype.exp
View File

@ -588,14 +588,10 @@ gdb_test "ptype foo" "type = char" "ptype foo typedef after second list of charf
# requires a running process. These call malloc, and can take a long
# time to execute over a slow serial link, so increase the timeout.
# UDI can't do this (PR 2416). XFAIL is not suitable, because attempting
# the operation causes a slow painful death rather than a nice simple failure.
if [runto_main] then {
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/structs.exp
View File

@ -20,8 +20,7 @@
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*"
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.base/unwindonsignal.exp
View File

@ -22,8 +22,7 @@ if [target_info exists gdb,nosignals] {
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.cp/gdb2495.exp
View File

@ -54,8 +54,7 @@ if [get_compiler_info "c++"] {
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.cp/templates.exp
View File

@ -184,8 +184,7 @@ proc test_template_calls {} {
global gdb_prompt
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
return
}

3
gdb/testsuite/gdb.cp/virtfunc.exp
View File

@ -177,8 +177,7 @@ proc test_virtual_calls {} {
global nl
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
return 0
}

3
gdb/testsuite/gdb.threads/hand-call-in-threads.exp
View File

@ -26,8 +26,7 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.threads/interrupted-hand-call.exp
View File

@ -27,8 +27,7 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}

3
gdb/testsuite/gdb.threads/thread-unwindonsignal.exp
View File

@ -27,8 +27,7 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
setup_xfail "*-*-*" 2416
fail "This target can not call functions"
unsupported "This target can not call functions"
continue
}